[GitHub] zeppelin pull request #3092: Java interpreter

2018-07-24 Thread selvinsource
GitHub user selvinsource opened a pull request: https://github.com/apache/zeppelin/pull/3092 Java interpreter ### What is this PR for? **New Java interpreter** There are several Java libraries that could be used to leverage the Data Visualization & Collaboration feature

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-07-25 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3092 @zjffdu thanks for reviewing the PR. Let me give you a bit of background before I answer your question on using another java interpreter. First of all, I found lately

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-07-25 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3092 @zjffdu as soon as this PR is merged in the master I will update the upstream master and start working on Jet interpreter, I have created a Jira ticket already (with a dependency on the Java

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-07-25 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3092 @zjffdu I made the requested changes except zeppelin.interpreter.group.order, should I just remove the whole property? I can't see where it's used to be honest. ---

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-07-26 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3092 @zjffdu I have done the rebase. ---

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-07-27 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3092 @zjffdu @felixcheung I have pushed the requested changes. ---

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-07-31 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3092 @zjffdu thanks @felixcheung should I mention explicitly that one cannot share variables between paragraph? I think other interpreters do not allow that either but it's not ment

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-01 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3092 @felixcheung I see what you mean now and I added explicitly to the Java Interpreter doc that the Java interpreter do not support it. Eventually, when we move the Java interpreter

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-01 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3092 @zjffdu yeah I think I understood and JShell should be able to achieve this. I meant as JavaContext a way to maintain the same JShell instance to run multiple snipper across paragraph in

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-02 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3092 @zjffdu I have made the change, if you can re-run Jenkins please. ---

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-02 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3092 @zjffdu yes I did before opening the pull request. I manually re-run it and it's fine now https://travis-ci.org/selvinsource/zeppelin/builds/411153675 ---

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-03 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3092 @zjffdu @felixcheung thanks for reviewing this PR and merging it in the master. I am going to work on the Hazelcast Jet interpreter next and send a new PR once ready. ---

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-06 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3092 @mebelousov If you see https://travis-ci.org/selvinsource/zeppelin/builds/411153675 it seems fine with SCALA_VER="2.11". What options are you running m

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-06 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3092 @zjffdu the issue reported by @mebelousov may have been caused by https://issues.apache.org/jira/browse/ZEPPELIN-3557 and not this PR, as I only added in the beam interpreter the

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-06 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3092 @zjffdu @mebelousov I sent you a comment before, please ignore, I thought that scio was only built for 2.10 but I noticed that changing scala version using the script does update the pom for

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-06 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3092 Found something that could cause the issue. in beam/pom.xml there is ```2.0.0``` then ``` beam-runners-flink_${scala.binary.version}``` But looking at

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-07 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3092 @felixcheung yes I think so as it's not something new, it has been there since the beam interpreter was created but nobody noticed until now that all interpreter specific profiles have

[GitHub] zeppelin pull request #3157: [ZEPPELIN-3654] - New Hazelcast Jet interpreter

2018-08-21 Thread selvinsource
GitHub user selvinsource opened a pull request: https://github.com/apache/zeppelin/pull/3157 [ZEPPELIN-3654] - New Hazelcast Jet interpreter ### What is this PR for? **New Hazelcast Jet interpreter** Zeppelin has interpreters for different data processing systems like

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-21 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3092 @felixcheung @zjffdu FYI, I have added https://issues.apache.org/jira/browse/ZEPPELIN-3742 based on the discussion we had in this PR. ---

[GitHub] zeppelin issue #3157: [ZEPPELIN-3654] - New Hazelcast Jet interpreter

2018-08-21 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3157 @felixcheung @zjffdu I have just opened the PR for the Hazelcast Jet interpreter as discussed before. Regarding the LICENSE file, I have a question. Do I need to put the license

[GitHub] zeppelin issue #3157: [ZEPPELIN-3654] - New Hazelcast Jet interpreter

2018-08-22 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3157 @zjffdu this PR is a start. As I said I still need to add Utils methods specific to Jet, in particular the Utils that convert the Jet DAG pipeline to a network graph using Zeppelin display

[GitHub] zeppelin issue #3157: [ZEPPELIN-3654] - New Hazelcast Jet interpreter

2018-09-08 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3157 I have added the support for Hazelcast JET DAG: https://user-images.githubusercontent.com/7315093/45251784-0b16ed00-b344-11e8-9c0e-41ca3b89b634.PNG";> Took me a while to

[GitHub] zeppelin issue #3157: [ZEPPELIN-3654] - New Hazelcast Jet interpreter

2018-09-20 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3157 @zjffdu I fixed the conflict and also updated the pom.xml for hazelcastjet due to ZEPPELIN-3774. ---

[GitHub] zeppelin issue #3157: [ZEPPELIN-3654] - New Hazelcast Jet interpreter

2018-09-26 Thread selvinsource
Github user selvinsource commented on the issue: https://github.com/apache/zeppelin/pull/3157 @zjffdu thanks a lot! ---