[GitHub] incubator-zeppelin pull request: ZEPPELIN-804 Refactoring registra...

2016-05-25 Thread echarles
Github user echarles commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/835#issuecomment-221787153 @jongyoul your conclusion are correct. I would also say there is something happeing with the zeppelin.R.render.options` nowt taken into account (the `echo

[GitHub] incubator-zeppelin pull request: ZEPPELIN-804 Refactoring registra...

2016-05-26 Thread echarles
Github user echarles commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/835#issuecomment-221816775 @jongyoul Building with both -Pr -Pspark may lead to unexpected behavior, even without the changes you brought... --- If your project is set up for it

[GitHub] incubator-zeppelin pull request: Make path for .spark-dist folder ...

2016-05-30 Thread echarles
GitHub user echarles opened a pull request: https://github.com/apache/incubator-zeppelin/pull/930 Make path for .spark-dist folder always accessible ### What is this PR for? Current Path for .spark-dist is outside the reactor, which can breaks build. [INFO

[GitHub] incubator-zeppelin pull request: Remove unnedeed commons-exec decl...

2016-05-30 Thread echarles
GitHub user echarles opened a pull request: https://github.com/apache/incubator-zeppelin/pull/931 Remove unnedeed commons-exec declaration in scope test [ZEPPELIN-904] ### What is this PR for? zeppelin-server should simply rely on transitive commons-exec from zeppelin

[GitHub] incubator-zeppelin pull request: Replace CXF with Jersey2 [ZEPPELI...

2016-05-30 Thread echarles
GitHub user echarles opened a pull request: https://github.com/apache/incubator-zeppelin/pull/932 Replace CXF with Jersey2 [ZEPPELIN-903] ### What is this PR for? Use jersey2 instead of CXF to manage JSON REST requests and responses. Jersey2 can better manage the JSON bodies

[GitHub] incubator-zeppelin pull request: Make path for .spark-dist folder always acc...

2016-05-31 Thread echarles
Github user echarles commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/930 @bzz Just commented on ZEPPELIN-902 - My concern was on my local build, not on Travis stability. As mentionned onthe JIRA, the target `target` folder is not present after a

[GitHub] incubator-zeppelin pull request: Make path for .spark-dist folder always acc...

2016-06-01 Thread echarles
Github user echarles commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/930 Tried with the ${session.executionRootDirectory} and got [ERROR] around Ant part ...

[GitHub] incubator-zeppelin issue #949: [ZEPPELIN-941] jsoup NoSuchMethodError in Zep...

2016-06-02 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/incubator-zeppelin/pull/949 Thx for jumping on this. It was mentioned on the mailing list, but seems like not everyone encounters this (maybe different maven options, profiles...) Going to first will solve

[GitHub] incubator-zeppelin issue #949: [ZEPPELIN-941] jsoup NoSuchMethodError in Zep...

2016-06-02 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/incubator-zeppelin/pull/949 All Green now. LGTM confirmed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-zeppelin issue #932: Replace CXF with Jersey2 [ZEPPELIN-903]

2016-06-02 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/incubator-zeppelin/pull/932 Any feedback on moving to jersey 2? (btw CI is green) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-zeppelin pull request #980: [ZEPPELIN-871] [WIP] spark 2.0 interpr...

2016-06-09 Thread echarles
GitHub user echarles opened a pull request: https://github.com/apache/incubator-zeppelin/pull/980 [ZEPPELIN-871] [WIP] spark 2.0 interpreter on scala 2.11 ### What is this PR for? Spark interpreter for spark version 2.0.0 and scala 2.11 (implemented in Scala) ### What

[GitHub] incubator-zeppelin issue #980: [ZEPPELIN-871] [WIP] spark 2.0 interpreter on...

2016-06-09 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/incubator-zeppelin/pull/980 This is WIP. I'd like to get feedback on the approach (scala implementation in the current spark module), taking into consideration: + Spark 2.0 will ship by def

[GitHub] incubator-zeppelin issue #980: [ZEPPELIN-871] [WIP] spark 2.0 interpreter on...

2016-06-09 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/incubator-zeppelin/pull/980 Sure, we can wait on #747 merge. I see there is a `spark/src/main/scala-2.11/org/apache/zeppelin/spark/SparkInterpreter.java`: does this mean that there will be 2 separate

[GitHub] zeppelin issue #980: [ZEPPELIN-871] [WIP] spark 2.0 interpreter on scala 2.1...

2016-06-12 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/980 Dealing with mixed scala 2.10/2.11 and spark 1.x/2.x with a same implementation is always possible but drives to code plenty of method invocation (see e.g. https://github.com/lresende/incubator

[GitHub] zeppelin issue #980: [ZEPPELIN-871] [WIP] spark 2.0 interpreter on scala 2.1...

2016-06-13 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/980 Agree with your agurment. If we push a bit further the discussion, we can not have a single binary which fits all users needs. What if I want spark-2-scala-2.11 with flink-0.9-scala-2.12 ? You

[GitHub] zeppelin issue #980: [ZEPPELIN-871] [WIP] spark 2.0 interpreter on scala 2.1...

2016-06-14 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/980 @Leemoonsoo - I was just saying that a single binary will not fit all various users need (multiple combination of interpeters and versions). - #629 is merged. What remains to get ZEPPELIN

[GitHub] zeppelin issue #980: [ZEPPELIN-871] [WIP] spark 2.0 interpreter on scala 2.1...

2016-06-14 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/980 @Leemoonsoo Oh, #908 is the one I was looking for --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #980: [ZEPPELIN-871] [WIP] spark 2.0 interpreter on scala 2.1...

2016-06-14 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/980 - If you ship in the same folder scala libs from different versions, it will at runtime - You don't have to rebuilt, but you have to arrange classpath is built with scala libs of the same ve

[GitHub] zeppelin issue #994: [ZEPPELIN-986] Create publish release script

2016-06-15 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/994 why spark is not published. is it related to the assembly? Btw, spark 2 doesn't use assembly any more and favor dependencies in separate jars. See https://issues.apache.org/jira/b

[GitHub] zeppelin issue #994: [ZEPPELIN-986] Create publish release script

2016-06-15 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/994 Didn't look at the code... just saw in the description (and @minahlee just confirmed it would be published). Thinking more about this PR: - Why the deploy and release plugins

[GitHub] zeppelin issue #994: [ZEPPELIN-986] Create publish release script

2016-06-15 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/994 Good to hear the release plugin is working fine. The release manager is responsible for the tools he wants. Fine to me if it is a script or a plugin, but at the end the artifacts must

[GitHub] zeppelin issue #993: [ZEPPELIN-987] Enable user to secure interpreter settin...

2016-06-15 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/993 @AhyoungRyu If you can come to an implementation that fits @prabhjyotsingh good idea, it would be great if you could make it `generic`, with a configurable list of functions that reflect in to

[GitHub] zeppelin issue #994: [ZEPPELIN-986] Create publish release script

2016-06-15 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/994 @minahlee thx for this precision and context. True, I just realized after sending the comment that repo is not part of zeppelin-server. However, I need zeppelin-server in my project (I

[GitHub] zeppelin issue #998: Authenticated user aware notebook storage layer

2016-06-16 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/998 LGTM I have tested and works well for me. Gone through the code and changes make sense. Will be useful to get it into 0.6 release (especially if #836 is also in 0.6, as

[GitHub] zeppelin issue #930: Make path for .spark-dist folder always accessible [ZEP...

2016-07-02 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/930 pong :) I don't see any solution for this. Does this issue bother anyone else? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] zeppelin issue #930: Make path for .spark-dist folder always accessible [ZEP...

2016-07-18 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/930 No, not ready. None of the envisaged solutions are practicable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #980: [ZEPPELIN-871] [WIP] spark 2.0 interpreter on scala 2.1...

2016-07-20 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/980 Closing this. Spark 2.0 is implemented with #1195 Optionally, a new PR can be opened to port the Spark interpreter from Java to Scala if interest. --- If your project is set up for it, you

[GitHub] zeppelin issue #1195: [ZEPPELIN-759] Spark 2.0 support

2016-07-20 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1195 Tested this with spark 2.0 and scala 2.11. Spark 2.0 works well with scala, R and python. @minahlee comment makes sense - we should ship the latest version. --- If your project is

[GitHub] zeppelin issue #932: Replace CXF with Jersey2 [ZEPPELIN-903]

2016-08-02 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/932 @Leemoonsoo Just pushed the asked changes regarding licenses. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1259: [ZEPPELIN-1260] R interpreter doesn't work with Spark ...

2016-08-02 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1259 @minahlee Just saw you comment on ZEPPELIN-1260, but @Leemoonsoo has been fast... I have tested the changes, and now sparkr dataframes are working well (with the `spark` variable which

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

2016-08-02 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1265 Quickly went through the changes, but not sure to get it. In which way is this related to the various intepreter modes we already have? In which way is this related to ZEPPELIN-1000

[GitHub] zeppelin issue #932: Replace CXF with Jersey2 [ZEPPELIN-903]

2016-08-02 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/932 Failing with org.apache.zeppelin.interpreter.InterpreterException: org.apache.thrift.TApplicationException: Internal error processing createInterpreter at

[GitHub] zeppelin issue #1259: [ZEPPELIN-1260] R interpreter doesn't work with Spark ...

2016-08-02 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1259 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #932: Replace CXF with Jersey2 [ZEPPELIN-903]

2016-08-05 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/932 @bzz I have updated the PR descrption (first comment) with the need to update license and adding a note on how easy it is with jersey to map a full json to a pojo being passed as method parameter

[GitHub] zeppelin issue #932: Replace CXF with Jersey2 [ZEPPELIN-903]

2016-08-17 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/932 @bzz I have moved `LICENSE-jersery-2` to `zeppelin-distribution/src/bin_license`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1322: [ZEPPELIN-1320] Run zeppelin interpreter process as we...

2016-08-22 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1322 Whatever `su` or `ssh` is used, I feel the main trick is the user provisioning on the host running the interpreter. Until now, the shiro authentication system had no impact on the user

[GitHub] zeppelin issue #1322: [ZEPPELIN-1320] Run zeppelin interpreter process as we...

2016-08-22 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1322 To make ZEPPELIN-1337 Umbrella for multiple user support for zeppelin more readable, should we rename the following: - ZEPPELIN-1340: "Run Hadoop-based interpreter process on Kerber

[GitHub] zeppelin issue #1322: [ZEPPELIN-1320] Run zeppelin interpreter process as we...

2016-08-22 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1322 ... and make ZEPPELIN-1320 a subtask of ZEPPELIN-1337 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1322: [ZEPPELIN-1320] Run zeppelin interpreter process as we...

2016-08-22 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1322 Btw, for the hadoop case (or spark on yarn case), this PR may give an issue for `doAs`. Typically, you configure `hadoop.proxyuser.foo.hosts` and `hadoop.proxyuser.foo.group`, `foo

[GitHub] zeppelin pull request #1361: [ZEPPELIN-1354] [WIP] Inject Services

2016-08-25 Thread echarles
GitHub user echarles opened a pull request: https://github.com/apache/zeppelin/pull/1361 [ZEPPELIN-1354] [WIP] Inject Services ### What is this PR for? Services like authentication, authorization, security filters... should be injected rather than manually instanciated

[GitHub] zeppelin issue #932: Replace CXF with Jersey2 [ZEPPELIN-903]

2016-08-25 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/932 @bzz are we ok now with the license information? Travis is red for 3 on the 9 profiles, but this comes from a timeout trying to launch/access spark ```16/08/17 15:36:04 INFO

[GitHub] zeppelin issue #1357: ZEPPELIN-1364: Return only the ran paragraph details f...

2016-08-25 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1357 Didn't try the changes but definitively +1 for this to enhance performance (tried to imagine side effects but didn't find any atm) --- If your project is set up for it, you can rep

[GitHub] zeppelin issue #932: Replace CXF with Jersey2 [ZEPPELIN-903]

2016-08-26 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/932 Merged with latest master. @bzz I don't know where I found CDDL 2.0 (sounded indeed strange when I was writing this some time ago). jax-rs is now CDDL 1.0, beanvalidation is now ASL2

[GitHub] zeppelin issue #1371: [ZEPPELIN-1372]Automatically Detect the data type in t...

2016-08-28 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1371 Upon numeric values, the automatic detection of dates... would be great. Detection at client (javascript) side could be misleading as you only get a subset of the data. On the

[GitHub] zeppelin issue #1371: [ZEPPELIN-1372]Automatically Detect the data type in t...

2016-08-28 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1371 @Peilin-Yang say you resultset is 50.000 lines, clients only have 1.000 lines (if I remember well). There is a risk your type guess is not correct. --- If your project is set up for it, you can

[GitHub] zeppelin pull request #1385: [ZEPPELIN-1395] Local or Remote Interpreter by ...

2016-08-29 Thread echarles
GitHub user echarles opened a pull request: https://github.com/apache/zeppelin/pull/1385 [ZEPPELIN-1395] Local or Remote Interpreter by Configuration ### What is this PR for? The current remote interpreter (launched via shell) is scalable and open but suffers from 2 limitations

[GitHub] zeppelin pull request #1390: [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] Note and ...

2016-08-31 Thread echarles
GitHub user echarles opened a pull request: https://github.com/apache/zeppelin/pull/1390 [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] Note and services per user ### What is this PR for? This implements "notes per user" and "Multiple-users on a single WEB server"

[GitHub] zeppelin issue #1390: [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] Note and service...

2016-09-01 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1390 @khalidhuseynov Good to discuss with you about what a multiuser note management would be. For the file system repo, this PR will give you: ``` ├── anonynmous │Â

[GitHub] zeppelin issue #1394: rename r directory to 2BWJFTXKJ

2016-09-02 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1394 @prabhjyotsingh yes, assumption is correct. At the time of the R interpreter dev, I was used to manually rename the note folder and edit the json to set the id the same value. This PR

[GitHub] zeppelin issue #1390: [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] [ZEPPELIN-1338] ...

2016-09-02 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1390 @zjffdu Correct, this PR also implements ZEPPELIN-1338 User level interpreter setting (I have updated the title and description on this PR). @Leemoonsoo Will check and adapt if needed

[GitHub] zeppelin issue #1385: [ZEPPELIN-1395] Local or Remote Interpreter by Configu...

2016-09-02 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1385 @astroshim Thx for the review. I have pushed a fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1385: [ZEPPELIN-1395] Local or Remote Interpreter by Configu...

2016-09-02 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1385 @jongyoul `ZeppelinConfiguration.create()` is now used and method signature are now like before. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #1390: [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] [ZEPPELIN-1338] ...

2016-09-05 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1390 I have introduced a parameter in the URL `?runAs=...` that allows to impersonate from an authenticated user another user. The needed R/W authorization are respected. An alternative

[GitHub] zeppelin issue #1330: [ZEPPELIN-1144]Zeppelin home page should only list not...

2016-09-05 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1330 If the current single `notebook-authorization.json` is managed by user (with multiple files, and no more with a single one), how would you handle it? --- If your project is set up for it, you

[GitHub] zeppelin issue #1390: [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] [ZEPPELIN-1338] ...

2016-09-06 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1390 @khalidhuseynov - have fixed the format issues - I didn't change Notebook#getNotebookAuthorization, it was already present. However, a single global NotebookAuthorization a

[GitHub] zeppelin issue #1385: [ZEPPELIN-1395] Local or Remote Interpreter by Configu...

2016-09-10 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1385 @jongyoul ZeppelinConfiguration is now remove also on that method. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin pull request #930: Make path for .spark-dist folder always accessib...

2016-09-12 Thread echarles
Github user echarles closed the pull request at: https://github.com/apache/zeppelin/pull/930 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #930: Make path for .spark-dist folder always accessible [ZEP...

2016-09-12 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/930 Closing this PR, I can not reproduce the issue anymore. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #932: Replace CXF with Jersey2 [ZEPPELIN-903]

2016-09-12 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/932 @bzz pushed my local merge. Anything else that should be done before you merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #1390: [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] [ZEPPELIN-1338] ...

2016-09-26 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1390 I have a prototype that supports the 3 modes. Give me a few days to polish and commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #1764: ZEPPELIN-1816. Implement getProgress in SparkRInterpre...

2016-12-19 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/1764 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2060: [ZEPPELIN-2094] Decrease npm install retry time

2017-03-07 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2060 I think this change breaks the installation of spell modules that are not yet published in npmjs repository. --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #2060: [ZEPPELIN-2094] Decrease npm install retry time

2017-03-07 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2060 I am adding a `json` file in the `helium` folder with the artifact that points to a full path on my local drive. In that location I have the spell project. It was working 3 days ago. Today, I

[GitHub] zeppelin issue #2112: [ZEPPELIN-2228] precode for SparkRInterpreter

2017-03-14 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2112 Would be good to generalize this precode execution to all interprerters, having methods like `prerun`, `postrun`... at `Interpeter` interface level. --- If your project is set up for it, you

[GitHub] zeppelin pull request #2226: [ZEPPELIN-2235] Helium load.js should reside in...

2017-04-05 Thread echarles
GitHub user echarles opened a pull request: https://github.com/apache/zeppelin/pull/2226 [ZEPPELIN-2235] Helium load.js should reside in subfolder + update babel and webpack versions ### What is this PR for? Changes are needed to make zeppelin-sigma-spell work. The

[GitHub] zeppelin pull request #2227: [ZEPPELIN-2359] Support Spell as Display

2017-04-05 Thread echarles
GitHub user echarles opened a pull request: https://github.com/apache/zeppelin/pull/2227 [ZEPPELIN-2359] Support Spell as Display ### What is this PR for? SPELL should be considered as another display type, just like TEXT, HTML, TABLE... ### What type of PR is it

[GitHub] zeppelin issue #2227: [ZEPPELIN-2359] Support Spell as Display

2017-04-08 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2227 @Leemoonsoo I wanted to introduce minimum changes in javascript and stay aligned with the idea of interpreters returning different display types. Introducing a new `spell` display has sounded

[GitHub] zeppelin issue #2226: [ZEPPELIN-2235] Helium load.js should reside in subfol...

2017-04-08 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2226 This is solved with #2210 Bundle helium packages one by one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin pull request #2226: [ZEPPELIN-2235] Helium load.js should reside in...

2017-04-08 Thread echarles
Github user echarles closed the pull request at: https://github.com/apache/zeppelin/pull/2226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2182: [ZEPPELIN-2248] Fix javax.ws.rs and cxf version mismat...

2017-04-16 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2182 How does this PR relates to #932 ? #932 simply replaces cxf with jersey2. Here I see we still have some cxf deps. --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #2182: [ZEPPELIN-2248] Fix javax.ws.rs and cxf version mismat...

2017-04-18 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2182 This issue is recurring since a long time and depends IMHO on each environment (maven version...) - The main parameter to fix this is the `javax.ws.rsapi.version`. This PR upgrades cxf

[GitHub] zeppelin issue #2227: [ZEPPELIN-2359] Support Spell as Display

2017-04-18 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2227 @Leemoonsoo @1ambda I see your point and agree with it. However, we need to decide which InterpreterResult to return. For now it can be { TABLE, IMG, SVG, NULL }. The Java code needs to

[GitHub] zeppelin issue #932: Replace CXF with Jersey2 [ZEPPELIN-903]

2017-05-04 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/932 Jenkins build is now green. @jongyoul @bzz Any other inputs/questions on this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #932: Replace CXF with Jersey2 [ZEPPELIN-903]

2017-05-07 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/932 It is working here with shiro-enabled (simple username password in shiro,ini, not the ldaprealm). I would need to test with ldaprealm... @sohaibiftikhar is it working for your with the

[GitHub] zeppelin issue #2227: [ZEPPELIN-2359] Support Spell as Display

2017-05-20 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2227 @1ambda thx a lot for the follow-up and your great work. This branch now supports what we want: ``` println("""%json {"array":[1,2,3],"boolean&

[GitHub] zeppelin issue #2227: [ZEPPELIN-2359] Support Spell as Display

2017-05-21 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2227 @1ambda I have added the log. Regarding you second comment, I am not sure what you mean. Is there something I should change? Is it not working as expected? --- If your project is set up for it

[GitHub] zeppelin issue #2418: [ZEPPELIN-2645] Adding way to register RemoteInterpret...

2017-07-03 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2418 I'd like adding more points to the discussion: - Do we need to support kerberos-like auth in the communication protocol (you can achieve this with Thrift, not sure with Netty)? -

[GitHub] zeppelin issue #2329: [ZEPPELIN-2040] ClusterManager to support launching in...

2017-07-03 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2329 Late question: This implementation uses the raw Yarn APIs. Did you consider using higher-level APIs such as Twill (http://twill.apache.org) or Slider (https://slider.incubator.apache.org

[GitHub] zeppelin issue #2418: [ZEPPELIN-2645] Adding way to register RemoteInterpret...

2017-07-03 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2418 In case of SNPEGO Web Auth (not yet supported by Zeppelin0,, you could consider transfert the Kerberos ticket from front-end to back-end and use it to , this the usecase I was thinking to

[GitHub] zeppelin issue #2418: [ZEPPELIN-2645] Adding way to register RemoteInterpret...

2017-07-06 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2418 @jongyoul sorry, I was not clear enough. With frontend, I was meaning the web layer (so jetty). Jetty could communicate via a variety of protocols to the interpreters. Now going further in that

[GitHub] zeppelin issue #2418: [ZEPPELIN-2645] Adding way to register RemoteInterpret...

2017-07-06 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2418 @zjffdu I am thinking to automation (using the notes in an scheduled or batch process). Does it make sense to you? --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #2637: Add support to run Spark interpreter on a Kubernetes c...

2017-11-09 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2637 @matyix I have a local spark-k8s setup and have this branch (without success so far, so debugging SparkK8RemoteInterpreterManagedProcess to tackle down the issue). A few questions: + I

[GitHub] zeppelin issue #2637: Add support to run Spark interpreter on a Kubernetes c...

2017-11-11 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2637 Just tried the `vanilla` (so without this #2637 PR) zeppelin on spark-k8s with the `in-cluster client mode` branch (https://github.com/apache-spark-on-k8s/spark/pull/456). It works fine

[GitHub] zeppelin issue #2637: Add support to run Spark interpreter on a Kubernetes c...

2017-11-14 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2637 @matyix I have tested your last commits and was able to make it work in my env (with both zeppelin `in-` and `out` k8s cluster). Your implement a new (specific for spark-k8s) launch and

[GitHub] zeppelin issue #2637: Add support to run Spark interpreter on a Kubernetes c...

2017-11-15 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2637 PS1: I have pushed my fixes in zeppelin-k8s/tree/spark-interpreter-k8s-fixes branch (which has merge conflict with master due to latest commit 3b1a03f that touch the launchers and remote

[GitHub] zeppelin issue #2637: Add support to run Spark interpreter on a Kubernetes c...

2017-11-19 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2637 Tested latest commit on AWS K8S cluster and works great as well in `client` as `cluster` modes - Kudos @matyix ---

[GitHub] zeppelin issue #2637: Add support to run Spark interpreter on a Kubernetes c...

2017-11-21 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2637 @matyix If my tests are correct, for now, we can not set `spark.app.name` and `spark.kubernetes.driver.pod.name` (if you set them, the driver will not be found by zeppelin). Upon that

[GitHub] zeppelin issue #2637: Add support to run Spark interpreter on a Kubernetes c...

2017-11-21 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2637 I am playing in cluster mode setting/removing via the interpreter page the `spark.app.name` and `spark.kubernetes.driver.pod.name` and so far the only to make it work (= remote executor finding

[GitHub] zeppelin issue #2637: Add support to run Spark interpreter on a Kubernetes c...

2017-11-21 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2637 @matyix I made a few more tests, and now `spark.app.name` and `spark.kubernetes.driver.pod.name` can be set without problem... (to be further confirmed). ---

[GitHub] zeppelin issue #2637: Add support to run Spark interpreter on a Kubernetes c...

2017-11-22 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2637 Thx @matyix. I will test and give feedback. Did you adding external dependencies (via the interpreter page). It works on my setup in `client` mode but fails (ClassNotFound) in `cluster

[GitHub] zeppelin issue #2637: Add support to run Spark interpreter on a Kubernetes c...

2017-11-23 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2637 @matyix There is a long history in Zeppelin on `spark.dep` vs `external dependency in interpreter settings`. I am fan of the later (interpreter settings), so if the --packages flag can make it

[GitHub] zeppelin issue #2637: Add support to run Spark interpreter on a Kubernetes c...

2017-11-23 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2637 @matyix sure, we can to address the dep in separate PR, especially if it is beneficial for all deploy modes. The downside of it is that we will have everybody happy with any change on deps

[GitHub] zeppelin issue #2637: Add support to run Spark interpreter on a Kubernetes c...

2017-11-29 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2637 @matyix I've given a try on you last commit and can not get the additional deps (in settings page) working. I don't see the `spark.jars` property in the generate c

[GitHub] zeppelin issue #2637: Add support to run Spark interpreter on a Kubernetes c...

2018-01-02 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2637 I still have issues with deps in cluster mode. @matyix Can you confirm it is working on your env? I will retest with your latest push in the coming days. But yes, absolutely, it will be

[GitHub] zeppelin issue #2637: Add support to run Spark interpreter on a Kubernetes c...

2018-01-08 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2637 Feedback/Question on latest commit: + For `cluster` mode, I sometimes receive a null pointer at first run, running a second time directly after is fine. + Are you enforcing the

[GitHub] zeppelin issue #2637: Add support to run Spark interpreter on a Kubernetes c...

2018-01-08 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2637 thx @matyix I had taken logs but don't have them anymore... but I can confirm that in both cases (deps via %spark.dep or via the ui) the command generated by the interpreter.sh is the sam

[GitHub] zeppelin issue #2730: ZEPPELIN-3166. R plotting resolution and image width i...

2018-01-14 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2730 `fig.retina` sounds like a good property to play with. However, fixing `out.width` to an arbitrary value may give good result for the example you give, but did you try with other plots

[GitHub] zeppelin issue #2730: ZEPPELIN-3166. R plotting resolution and image width i...

2018-01-15 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2730 Agree, but the default will always find case where it will not work. For this image size / resolution, there may be more failure than success I am afraid. To be tested with various plots, screen

[GitHub] zeppelin issue #2730: ZEPPELIN-3166. R plotting resolution and image width i...

2018-01-15 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2730 GTM ---

[GitHub] zeppelin issue #2404: fix bugs for: when interpreter setting restart of one ...

2018-03-12 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2404 @wary I am facing the same issue (all paragraphs aborted on interpreter restart in isolate per user configuration). I see you have deleted your branch and that the proposed patch does not apply

  1   2   >