[GitHub] incubator-zeppelin pull request: ZeppelinHub notebook storage/conn...

2016-05-28 Thread anthonycorbacho
Github user anthonycorbacho commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/880#issuecomment-222325060 @bzz I took the liberty of merging it, i badly needed this :) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1119: [DOC] Zeppelin 0.6.0 release note

2016-07-04 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1119 This [issue](https://issues.apache.org/jira/browse/ZEPPELIN-1104) is missing from the release note --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin pull request #1173: ZeppelinHub Realm

2016-07-12 Thread anthonycorbacho
GitHub user anthonycorbacho opened a pull request: https://github.com/apache/zeppelin/pull/1173 ZeppelinHub Realm ### What is this PR for? Add a new Shiro Realm that lets users authenticate in Apache Zeppelin using their ZeppelinHub credentials. ### What type of PR is

[GitHub] zeppelin issue #1160: [Zeppelin - 1152] Listing note revision history

2016-07-19 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1160 @khalidhuseynov what is the benefit of having a new websocket call? will rest api call be enough? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin pull request #1173: [ZEPPELIN-1164] ZeppelinHub Realm

2016-07-20 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1173 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1173: [ZEPPELIN-1164] ZeppelinHub Realm

2016-07-20 Thread anthonycorbacho
GitHub user anthonycorbacho reopened a pull request: https://github.com/apache/zeppelin/pull/1173 [ZEPPELIN-1164] ZeppelinHub Realm ### What is this PR for? Add a new Shiro Realm that lets users authenticate in Apache Zeppelin using their ZeppelinHub credentials

[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm

2016-07-20 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1173 all green --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm

2016-07-20 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1173 @khalidhuseynov i think it make sense to do it in this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm

2016-07-21 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1173 @khalidhuseynov @AhyoungRyu 5a27871f5a9e436653c8862e6d2ecc8913fdd496 for documentation --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm

2016-07-22 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1173 merging if no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm

2016-08-03 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1173 @jongyoul sure, no problemo Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1251: [ZEPPELIN-1256][BUILD] Build distribution package with...

2016-08-04 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1251 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-08-10 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1304 @khalidhuseynov are we really sure about sending `complex object` as a parameter in the URL? How will it be represented? encoded? IMO it is not a good idea, if you ask for a

[GitHub] zeppelin issue #1254: [ZEPPELIN-1257] storage - fix get note revision api

2016-08-15 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1254 @bzz can you merge it asap? i need this change if i want to continue my work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin pull request #1338: [WIP ] Zeppelin 1307 - Implement notebook revis...

2016-08-17 Thread anthonycorbacho
GitHub user anthonycorbacho opened a pull request: https://github.com/apache/zeppelin/pull/1338 [WIP ] Zeppelin 1307 - Implement notebook revision in Zeppelinhub repo ### What is this PR for? Implement versioning in ZeppelinHub notebook storage. ### What type of PR is

[GitHub] zeppelin pull request #1338: [WIP ] Zeppelin 1307 - Implement notebook revis...

2016-08-17 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1338 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1338: [WIP ] Zeppelin 1307 - Implement notebook revis...

2016-08-17 Thread anthonycorbacho
GitHub user anthonycorbacho reopened a pull request: https://github.com/apache/zeppelin/pull/1338 [WIP ] Zeppelin 1307 - Implement notebook revision in Zeppelinhub repo ### What is this PR for? Implement versioning in ZeppelinHub notebook storage. ### What type of PR is

[GitHub] zeppelin issue #1340: [MINOR][DOC] Update available interpreters' image in i...

2016-08-18 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1340 Can you order them alphabetically ? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1344: ZEPPELIN-1164: backport new Shiro realm to 0.6 branch

2016-08-18 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1344 look good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1338: Zeppelin 1307 - Implement notebook revision in Zeppeli...

2016-08-18 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1338 ready for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #1338: Zeppelin 1307 - Implement notebook revision in Zeppeli...

2016-08-21 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1338 **L**ets **G**et **T**o **M**erge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1338: Zeppelin 1307 - Implement notebook revision in Zeppeli...

2016-08-21 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1338 @bzz Regarding your comment, I couldnt agree more, i am not a big fan of returning `null`. I created an issue in [JIRA - 1352](https://issues.apache.org/jira/browse/ZEPPELIN-1352) and I

[GitHub] zeppelin issue #1338: Zeppelin 1307 - Implement notebook revision in Zeppeli...

2016-08-22 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1338 merging if no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1338: Zeppelin 1307 - Implement notebook revision in Zeppeli...

2016-08-22 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1338 @khalidhuseynov fixed the issue, thank for testing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1483: [ZEPPELIN-1509] Run certain SparkInterpreter tests onl...

2016-10-04 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1483 Changes look good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1482: ZEPPELIN-1410 SLF4J: Class path contains multiple SLF4...

2016-10-04 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1482 Changes look good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1496: [Zeppelin-907] Apply new mechanism to AngularInterpret...

2016-10-08 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1496 @vectorijk thank you for the contribution the change look good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #1498: [DOCS] Fix dead link in docs/datasource_authorization....

2016-10-08 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1498 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1494: [ZEPPELIN-451] Save codes and messages as multi-line

2016-10-09 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1494 @sixmen thank you for your contribution, this feature looks AWESOME. I didnt dive into the code, but one question came in my mind; This change is kinda *breaking change* since

[GitHub] zeppelin issue #1505: [HOTFIX] Set default ZEPPELIN_INTP_MEM

2016-10-11 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1505 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1497: [ZEPPELIN-1233] Support Redis interpreter

2016-10-11 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1497 @darionyaphet do you need some help for the change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1517: [MINOR] ui improvement

2016-10-14 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1517 Change looks great to me, that you for your contribution. Awesome! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #1497: [ZEPPELIN-1233] Support Redis interpreter

2016-10-15 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1497 @HeartSaVioR thank you for pointing that out, you are right we better handle the potential `JedisException` exception to avoid leak. --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #1528: [DOC] Release Apache Zeppelin 0.6.2

2016-10-16 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1528 LG*reat*TM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1515: [ZEPPELIN-916] Apply new mechanism to KylinInterpreter

2016-10-16 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1515 look good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1392: [ZEPPELIN-1437, 1438] Multi-user note management - use...

2016-10-17 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1392 @Leemoonsoo is it possible to merge it in couple of hour? some of my work will depends on this PR :) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1536: [Zeppelin 796] Duplicated notebook names should not be...

2016-10-18 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1536 I think its okay to have a duplicate name, if the noteId is different nothing bad will happen. What kind of case are you trying to solve here? --- If your project is set up for it, you

[GitHub] zeppelin issue #1536: [Zeppelin 796] Duplicated notebook names should not be...

2016-10-18 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1536 I see your point, but let say i want to import a note and i have a note with the same name, it will not allow me to do that and i feel like its a pretty bad user experience here. What do

[GitHub] zeppelin issue #1497: [ZEPPELIN-1233] Support Redis interpreter

2016-10-22 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1497 @HeartSaVioR yeah i would love to have a class that manipulate redis cmd and handle null, ussually i am not a huge fan of returning `null`, i would prefer to return an `EMPTY` type

[GitHub] zeppelin issue #1542: [MINOR][DOC] Fix typo (re-open PR #1541 with rebase)

2016-10-22 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1542 Changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin pull request #1553: [ZEPPELIN-1575] [WIP] Notebook Repo settings UI

2016-10-22 Thread anthonycorbacho
GitHub user anthonycorbacho opened a pull request: https://github.com/apache/zeppelin/pull/1553 [ZEPPELIN-1575] [WIP] Notebook Repo settings UI ### What is this PR for? Let user configure/change notebook repo setting via Zeppelin UI We can imagine one case with

[GitHub] zeppelin issue #1537: [Zeppelin-1561] Improve sync for multiuser environment...

2016-10-23 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1537 LGTM merging if no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1553: [ZEPPELIN-1575] Notebook Repo settings UI

2016-10-24 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1553 @khalidhuseynov added some tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin pull request #1553: [ZEPPELIN-1575] Notebook Repo settings UI

2016-10-25 Thread anthonycorbacho
GitHub user anthonycorbacho reopened a pull request: https://github.com/apache/zeppelin/pull/1553 [ZEPPELIN-1575] Notebook Repo settings UI ### What is this PR for? The idea behind this feature is to bring flexibility to the user to let him configure his repo via UI without

[GitHub] zeppelin pull request #1553: [ZEPPELIN-1575] Notebook Repo settings UI

2016-10-25 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1553 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1553: [ZEPPELIN-1575] Notebook Repo settings UI

2016-10-25 Thread anthonycorbacho
GitHub user anthonycorbacho reopened a pull request: https://github.com/apache/zeppelin/pull/1553 [ZEPPELIN-1575] Notebook Repo settings UI ### What is this PR for? The idea behind this feature is to bring flexibility to the user to let him configure his repo via UI without

[GitHub] zeppelin pull request #1553: [ZEPPELIN-1575] Notebook Repo settings UI

2016-10-25 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1553 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1553: [ZEPPELIN-1575] Notebook Repo settings UI

2016-10-25 Thread anthonycorbacho
GitHub user anthonycorbacho reopened a pull request: https://github.com/apache/zeppelin/pull/1553 [ZEPPELIN-1575] Notebook Repo settings UI ### What is this PR for? The idea behind this feature is to bring flexibility to the user to let him configure his repo via UI without

[GitHub] zeppelin pull request #1553: [ZEPPELIN-1575] Notebook Repo settings UI

2016-10-25 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1553 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1553: [ZEPPELIN-1575] Notebook Repo settings UI

2016-10-25 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1553 Please review this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1553: [ZEPPELIN-1575] Notebook Repo settings UI

2016-10-25 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1553 If no more discussion i am going to merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1540: [ZEPPELIN-1566] Make paragraph editable with double cl...

2016-10-27 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1540 Awesome, **LGTM** --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-10-28 Thread anthonycorbacho
GitHub user anthonycorbacho opened a pull request: https://github.com/apache/zeppelin/pull/1567 [ZEPPELIN-1586] Add security check in NotebookRestApi ### What is this PR for? Bring some security check in `NotebookRestApi`. ### What type of PR is it? [Bug Fix

[GitHub] zeppelin pull request #1568: [ZEPPELIN-1590] Move shiro.ini to shiro.ini.tem...

2016-10-29 Thread anthonycorbacho
GitHub user anthonycorbacho opened a pull request: https://github.com/apache/zeppelin/pull/1568 [ZEPPELIN-1590] Move shiro.ini to shiro.ini.template ### What is this PR for? Move shiro.ini to shiro,ini.template for consistency. ### What type of PR is it

[GitHub] zeppelin pull request #1571: [DOC] Update shiro after merging #1568

2016-10-31 Thread anthonycorbacho
GitHub user anthonycorbacho opened a pull request: https://github.com/apache/zeppelin/pull/1571 [DOC] Update shiro after merging #1568 ### What is this PR for? A simple update of the documentation to let user know how that they need to copy `shiro.ini.template` to `shiro.ini

[GitHub] zeppelin issue #1571: [DOC] Update shiro after merging #1568

2016-10-31 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1571 merging if no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin pull request #1571: [DOC] Update shiro after merging #1568

2016-10-31 Thread anthonycorbacho
GitHub user anthonycorbacho reopened a pull request: https://github.com/apache/zeppelin/pull/1571 [DOC] Update shiro after merging #1568 ### What is this PR for? A simple update of the documentation to let user know how that they need to copy `shiro.ini.template` to `shiro.ini

[GitHub] zeppelin pull request #1571: [DOC] Update shiro after merging #1568

2016-10-31 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1571: [DOC] Update shiro after merging #1568

2016-10-31 Thread anthonycorbacho
GitHub user anthonycorbacho reopened a pull request: https://github.com/apache/zeppelin/pull/1571 [DOC] Update shiro after merging #1568 ### What is this PR for? A simple update of the documentation to let user know how that they need to copy `shiro.ini.template` to `shiro.ini

[GitHub] zeppelin pull request #1571: [DOC] Update shiro after merging #1568

2016-10-31 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-10-31 Thread anthonycorbacho
GitHub user anthonycorbacho reopened a pull request: https://github.com/apache/zeppelin/pull/1567 [ZEPPELIN-1586] Add security check in NotebookRestApi ### What is this PR for? Bring some security check in `NotebookRestApi`. ### What type of PR is it? [Bug Fix

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-10-31 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-11-01 Thread anthonycorbacho
GitHub user anthonycorbacho reopened a pull request: https://github.com/apache/zeppelin/pull/1567 [ZEPPELIN-1586] Add security check in NotebookRestApi ### What is this PR for? Bring some security check in `NotebookRestApi`. ### What type of PR is it? [Bug Fix

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-11-01 Thread anthonycorbacho
GitHub user anthonycorbacho reopened a pull request: https://github.com/apache/zeppelin/pull/1567 [ZEPPELIN-1586] Add security check in NotebookRestApi ### What is this PR for? Bring some security check in `NotebookRestApi`. ### What type of PR is it? [Bug Fix

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1567 @minahlee yeah, actually i am doing this right now, I also updated to todo tasks thanks for your review! --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1567 @minahlee you are right, I guess the next step will be to abstract this logic from rest api and apply to both rest and websocket. --- If your project is set up for it, you can reply to

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1567 @tae-jun thanks for the feedback, let me take a look tomorrow --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1567 @tae-jun After looking at the code base, I think this case should be handle in another PR, this is kinda out of the scope of this PR and its already becoming super big. But your

[GitHub] zeppelin pull request #1571: [DOC] Update shiro after merging #1568

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1567 @zjffdu Hey dudy I keep failing at Livy interpreter, i dont know why but i keep getting timeout somehow, can you take a look t it please? It also look like other pr are failing at the

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-11-01 Thread anthonycorbacho
GitHub user anthonycorbacho reopened a pull request: https://github.com/apache/zeppelin/pull/1567 [ZEPPELIN-1586] Add security check in NotebookRestApi ### What is this PR for? Bring some security check in `NotebookRestApi`. ### What type of PR is it? [Bug Fix

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1567 @tae-jun creating an issue doenst mean that you have to handle it, of course if you want you are welcome to do so, but remember we are a community so that mean we are here to help each

[GitHub] zeppelin issue #1575: ZEPPELIN-1597. Change cdh spark/hadoop dependency to a...

2016-11-02 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1575 @minahlee yes please merge it asap this a total war zone here --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-11-02 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-11-02 Thread anthonycorbacho
GitHub user anthonycorbacho reopened a pull request: https://github.com/apache/zeppelin/pull/1567 [ZEPPELIN-1586] Add security check in NotebookRestApi ### What is this PR for? Bring some security check in `NotebookRestApi`. ### What type of PR is it? [Bug Fix

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-11-02 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-11-02 Thread anthonycorbacho
GitHub user anthonycorbacho reopened a pull request: https://github.com/apache/zeppelin/pull/1567 [ZEPPELIN-1586] Add security check in NotebookRestApi ### What is this PR for? Bring some security check in `NotebookRestApi`. ### What type of PR is it? [Bug Fix

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-02 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1567 Yeaay! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1583: [MINOR] Turn on authenticaiton in shiro.ini.template b...

2016-11-03 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1583 merging if no more discussion ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1583: [MINOR] Turn on authenticaiton in shiro.ini.template b...

2016-11-03 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1583 Good catch! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin pull request #1588: [ZEPPELIN-1610] [WIP] - Add notebook watcher

2016-11-03 Thread anthonycorbacho
GitHub user anthonycorbacho opened a pull request: https://github.com/apache/zeppelin/pull/1588 [ZEPPELIN-1610] [WIP] - Add notebook watcher ### What is this PR for? Add a Simple way to switch a websocket connection to a new state; watcher. A websocket watcher is a special

[GitHub] zeppelin pull request #1591: Fix latency on notebook save in ZeppelinHubNote...

2016-11-03 Thread anthonycorbacho
GitHub user anthonycorbacho opened a pull request: https://github.com/apache/zeppelin/pull/1591 Fix latency on notebook save in ZeppelinHubNotebookRepo ### What is this PR for? Fix latency issue when user save a notebook while using zeppelinhub notebook storage

[GitHub] zeppelin issue #1592: [ZEPPELIN-1029] Add rest api for paragraph config upda...

2016-11-03 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1592 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1565: [ZEPPELIN-1564] Enable note deletion and paragraph out...

2016-11-03 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1565 @tae-jun This is a great sum of the status of the rest api in zeppelin, and i think we all agree that currently zeppelin doenst follow rest standard (just by looking at the endpoint

[GitHub] zeppelin pull request #1595: [ZEPPELIN-1615] - Zeppelin should be able to ru...

2016-11-03 Thread anthonycorbacho
GitHub user anthonycorbacho opened a pull request: https://github.com/apache/zeppelin/pull/1595 [ZEPPELIN-1615] - Zeppelin should be able to run without Shiro ### What is this PR for? Right now, Zeppelin use Shiro by default even if you dont need it. (It will use

[GitHub] zeppelin issue #1591: Fix latency on notebook save in ZeppelinHubNotebookRep...

2016-11-03 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1591 travis is super slow today Amerika is working to hard today :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #1583: [MINOR] Turn on authenticaiton in shiro.ini.template b...

2016-11-04 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1583 #1595 will fix this issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1595: [ZEPPELIN-1615] - Zeppelin should be able to run witho...

2016-11-04 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1595 Hell yeah!!! I allow you to merge it :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1591: Fix latency on notebook save in ZeppelinHubNotebookRep...

2016-11-04 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1591 CI is failing due to `testEditOnDoubleClick`, and it is not related to this PR. So i am merging it :) --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin pull request #1604: [HOT-FIX] - Prevent double injection of cross-o...

2016-11-04 Thread anthonycorbacho
GitHub user anthonycorbacho opened a pull request: https://github.com/apache/zeppelin/pull/1604 [HOT-FIX] - Prevent double injection of cross-origin headers from rest api ### What is this PR for? Prevent error `XMLHttpRequest cannot load http://localhost:8080/api/version. The

[GitHub] zeppelin issue #1595: [ZEPPELIN-1615] - Zeppelin should be able to run witho...

2016-11-04 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1595 @Leemoonsoo thank you for the feedback, please fix the fix under PR #1604 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1597: Shorten certain error logs in order to keep CI logs cl...

2016-11-05 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1597 @khalidhuseynov its a know issue: logged here https://issues.apache.org/jira/browse/ZEPPELIN-1623 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1604: [HOT-FIX] - Prevent double injection of cross-origin h...

2016-11-05 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1604 Mergin it as a hot fix! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1588: [ZEPPELIN-1610] - Add notebook watcher

2016-11-13 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1588 @Leemoonsoo addressed your review, please let me know --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1588: [ZEPPELIN-1610] - Add notebook watcher

2016-11-14 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1588 @Leemoonsoo looks like tests are falling for random reason... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1588: [ZEPPELIN-1610] - Add notebook watcher

2016-11-14 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1588 CI is green after ~10 retry ![53997955](https://cloud.githubusercontent.com/assets/3139557/20270079/055785e4-aac9-11e6-85e5-2b0b378a3ffd.jpg) --- If your project is set up for

[GitHub] zeppelin pull request #1635: [WIP] - ZeppelinHubNotebookRepo multy user hand...

2016-11-15 Thread anthonycorbacho
GitHub user anthonycorbacho opened a pull request: https://github.com/apache/zeppelin/pull/1635 [WIP] - ZeppelinHubNotebookRepo multy user handling ### What is this PR for? This PR bring multi user handling to ZeppelinHubNotebookRepo. ### What type of PR is it

  1   2   >