[GitHub] [zeppelin] kp-incelligent commented on pull request #4603: fix maven dependency convergence errors

2023-05-18 Thread via GitHub
kp-incelligent commented on PR #4603: URL: https://github.com/apache/zeppelin/pull/4603#issuecomment-1552738528 My bad, I was running it with ` mvn clean package -DskipTests` which uses the system's Maven ``` Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-2

[GitHub] [zeppelin] kp-incelligent closed pull request #4603: fix maven dependency convergence errors

2023-05-18 Thread via GitHub
kp-incelligent closed pull request #4603: fix maven dependency convergence errors URL: https://github.com/apache/zeppelin/pull/4603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [zeppelin] zhugezifang commented on pull request #4598: [ZEPPELIN-5896]feat:add sql debug feature

2023-05-18 Thread via GitHub
zhugezifang commented on PR #4598: URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1552873939 > I am very unhappy with the code quality and therefore will not pursue this feature. Another reviewer is welcome to ask my opinion once the code is clean. In my opinion, most of the

[jira] [Created] (ZEPPELIN-5912) Can't resolve 'scrollmonitor/scrollMonitor.js' in '/workspace/zeppelin/zeppelin-web/src/app'

2023-05-18 Thread Perla Al Haddad (Jira)
Perla Al Haddad created ZEPPELIN-5912: - Summary: Can't resolve 'scrollmonitor/scrollMonitor.js' in '/workspace/zeppelin/zeppelin-web/src/app' Key: ZEPPELIN-5912 URL: https://issues.apache.org/jira/browse/ZEPPE

[GitHub] [zeppelin] zhugezifang commented on pull request #4598: [ZEPPELIN-5896]feat:add sql debug feature

2023-05-18 Thread via GitHub
zhugezifang commented on PR #4598: URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1553035671 > Thank you for your contribution. I already saw some comments by @Reamer but I also could see some style issue. (Yes, Zeppelin doesn't have very-very strict rules for styling but I