[GitHub] [zeppelin] Reamer commented on pull request #4602: [ZEPPELIN-5897] Remove launcher properties and only use the current context properties

2023-05-17 Thread via GitHub
Reamer commented on PR #4602: URL: https://github.com/apache/zeppelin/pull/4602#issuecomment-1550934923 I will observe this feature a bit more in my productive environment. So far, everything looks very good. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4598: [ZEPPELIN-5896]feat:add sql debug feature

2023-05-17 Thread via GitHub
Reamer commented on code in PR #4598: URL: https://github.com/apache/zeppelin/pull/4598#discussion_r1196585537 ## zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java: ## @@ -1624,6 +1629,79 @@ public void onSuccess(Paragraph p, ServiceContext context) t

[GitHub] [zeppelin] kp-incelligent opened a new pull request, #4603: fix maven dependency convergence errors

2023-05-17 Thread via GitHub
kp-incelligent opened a new pull request, #4603: URL: https://github.com/apache/zeppelin/pull/4603 Hello. I got the following Maven errors when trying to build from source (current master branch): ``` [INFO] --< org.apache.zeppelin:zeppelin-interpreter >--

[GitHub] [zeppelin] Reamer commented on pull request #4603: fix maven dependency convergence errors

2023-05-17 Thread via GitHub
Reamer commented on PR #4603: URL: https://github.com/apache/zeppelin/pull/4603#issuecomment-1551529562 What is your Maven call? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [zeppelin] Reamer commented on pull request #4581: [ZEPPELIN-5901] k8s interpreter pod launch fails

2023-05-17 Thread via GitHub
Reamer commented on PR #4581: URL: https://github.com/apache/zeppelin/pull/4581#issuecomment-1551599673 I created https://github.com/grizzly-monkey/zeppelin/pull/1 to fix this feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zeppelin] zhugezifang commented on pull request #4598: [ZEPPELIN-5896]feat:add sql debug feature

2023-05-17 Thread via GitHub
zhugezifang commented on PR #4598: URL: https://github.com/apache/zeppelin/pull/4598#issuecomment-1552299344 > I am very unhappy with the code quality and therefore will not pursue this feature. Another reviewer is welcome to ask my opinion once the code is clean. In my opinion, most of the