[GitHub] [zeppelin] Reamer commented on a diff in pull request #4321: [ZEPPELIN-5612] Upgrade junit 4 to 5

2022-11-11 Thread GitBox
Reamer commented on code in PR #4321: URL: https://github.com/apache/zeppelin/pull/4321#discussion_r1020028572 ## hbase/pom.xml: ## @@ -75,11 +75,23 @@ org.apache.hbase hbase-client ${hbase.hbase.version} + Review Comment: This is not a test depend

[GitHub] [zeppelin] zjffdu commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2022-11-11 Thread GitBox
zjffdu commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1311620071 Will merge if no more comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] Reamer commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2022-11-11 Thread GitBox
Reamer commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1311633222 > Will merge if no more comments No automated tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [zeppelin] zjffdu commented on pull request #4506: [ZEPPELIN-5844] Support flink 1.16

2022-11-11 Thread GitBox
zjffdu commented on PR #4506: URL: https://github.com/apache/zeppelin/pull/4506#issuecomment-1311634940 > > Will merge if no more comments > > No automated tests? Oops, missing in the commit, let me add it. -- This is an automated message from the Apache Git Service. To resp