huage1994 commented on PR #4368:
URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1127446019
> I do not like this solution and would "veto" it. The readability and
simplicity of the code suffers greatly with this change. I would prefer a
conversion directly at the call (e.g.
Reamer commented on PR #4368:
URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1127452381
> How do you think about it?
Much better.
Another improvement `timeUnitToMill` should throw an exception instead of
returning `-1`. This exception should be caught and react
huage1994 commented on PR #4368:
URL: https://github.com/apache/zeppelin/pull/4368#issuecomment-1127457238
> Another improvement `timeUnitToMill` should throw an exception instead of
returning `-1`. This exception should be caught and reacted to.
👍 Thanks a lot for your advice!
Reamer opened a new pull request, #4369:
URL: https://github.com/apache/zeppelin/pull/4369
### What is this PR for?
This pull request is to prevent a deadlock which occurs in connection with a
fast cancel in the LazyOpenInterpreter.
This PR should also correct the closing of interp
