[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4308: [Zeppelin-5655] OSSNotebookRepo support version control.

huage1994 commented on code in PR #4308: URL: https://github.com/apache/zeppelin/pull/4308#discussion_r855016501 ## docs/setup/storage/storage.md: ## @@ -454,6 +454,16 @@ And you should configure oss related properties in file **zeppelin-site.xml**. Access key secret for you

[GitHub] [zeppelin] huage1994 commented on pull request #4362: [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api

huage1994 commented on PR #4362: URL: https://github.com/apache/zeppelin/pull/4362#issuecomment-1105024368 😂 I just add a method in Zeppelin Client and do nothing else. It's so strange that the CI tasks failed. And I re-run CI tasks twice in my own forked zeppelin repository, they still

[GitHub] [zeppelin] Reamer commented on pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

Reamer commented on PR #4355: URL: https://github.com/apache/zeppelin/pull/4355#issuecomment-1105447197 @zjffdu For a first feedback I would be very grateful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [zeppelin] zjffdu commented on pull request #4362: [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api

zjffdu commented on PR #4362: URL: https://github.com/apache/zeppelin/pull/4362#issuecomment-1105921869 > 😅 I just add a method in Zeppelin Client and do nothing else. It's so strange that the CI tasks failed. And I re-run CI tasks twice in my own forked zeppelin repository, they st

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

zjffdu commented on code in PR #4355: URL: https://github.com/apache/zeppelin/pull/4355#discussion_r855713929 ## zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterLauncher.java: ## @@ -54,11 +57,11 @@ public InterpreterClien

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

zjffdu commented on code in PR #4355: URL: https://github.com/apache/zeppelin/pull/4355#discussion_r855714012 ## zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterLauncher.java: ## @@ -54,11 +57,11 @@ public InterpreterClien

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

zjffdu commented on code in PR #4355: URL: https://github.com/apache/zeppelin/pull/4355#discussion_r855715546 ## zeppelin-plugins/notebookrepo/mongo/src/main/java/org/apache/zeppelin/notebook/repo/MongoPlugin.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4355: [DRAFT] [ZEPPELIN-5722] Improve PluginManager

zjffdu commented on code in PR #4355: URL: https://github.com/apache/zeppelin/pull/4355#discussion_r855715888 ## zeppelin-zengine/pom.xml: ## @@ -40,6 +40,7 @@ 1.3 2.6.0 4.5.4.201711221230-r +3.6.0 Review Comment: It is also defined in root pom.xml --