[GitHub] [zeppelin] zjffdu commented on pull request #4343: [ZEPPELIN-5706] Add missing license headers related to the notebook exclusion

2022-04-06 Thread GitBox
zjffdu commented on PR #4343: URL: https://github.com/apache/zeppelin/pull/4343#issuecomment-1090076106 I think we need to update the rat plugin rule as well, so that CI can help us to detect the missing header files -- This is an automated message from the Apache Git Service. To respond

[GitHub] [zeppelin] zjffdu commented on pull request #4338: [ZEPPELIN-5705] Incorrect scala version checking in SparkSqlInterpreter.java

2022-04-06 Thread GitBox
zjffdu commented on PR #4338: URL: https://github.com/apache/zeppelin/pull/4338#issuecomment-1090078214 Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] jongyoul merged pull request #4338: [ZEPPELIN-5705] Incorrect scala version checking in SparkSqlInterpreter.java

2022-04-06 Thread GitBox
jongyoul merged PR #4338: URL: https://github.com/apache/zeppelin/pull/4338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apa

[jira] [Created] (ZEPPELIN-5709) AuthorizationService.isRunner always return true if there's no user/roles info in context

2022-04-06 Thread Peter Lee (Jira)
Peter Lee created ZEPPELIN-5709: --- Summary: AuthorizationService.isRunner always return true if there's no user/roles info in context Key: ZEPPELIN-5709 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5709

[jira] [Created] (ZEPPELIN-5710) make hadoop 2.10.1 the minimum support hadoop version

2022-04-06 Thread PJ Fanning (Jira)
PJ Fanning created ZEPPELIN-5710: Summary: make hadoop 2.10.1 the minimum support hadoop version Key: ZEPPELIN-5710 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5710 Project: Zeppelin

[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4336: [ZEPPELIN-5699] Trim space in ConfInterpreter

2022-04-06 Thread GitBox
zjffdu commented on code in PR #4336: URL: https://github.com/apache/zeppelin/pull/4336#discussion_r844565823 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/ConfInterpreter.java: ## @@ -67,6 +67,9 @@ public InterpreterResult interpret(String st, InterpreterCo

[GitHub] [zeppelin] zjffdu commented on pull request #4308: [Zeppelin-5655] OSSNotebookRepo support version control.

2022-04-06 Thread GitBox
zjffdu commented on PR #4308: URL: https://github.com/apache/zeppelin/pull/4308#issuecomment-1091000866 Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] zjffdu opened a new pull request, #4345: [ZEPPELIN-5697] Remove old planner support of flink

2022-04-06 Thread GitBox
zjffdu opened a new pull request, #4345: URL: https://github.com/apache/zeppelin/pull/4345 ### What is this PR for? The old planner is removed starting from Flink 1.14. It is only used by a few users in some uncommon scenarios. This PR is to remove it from Flink interpreter to reduce

Re: GitHub Merging

2022-04-06 Thread Jeff Zhang
Jongyoul's right, I think both approaches work. BTW, we also need to update the jira ticket if using github merge On Wed, Apr 6, 2022 at 12:47 PM Jongyoul Lee wrote: > Yeap. > > I just merged it with Github's "Squash and Merge" button. I also wonder > which is better but I feel like both are ok

[jira] [Created] (ZEPPELIN-5711) Zeppelin0.10: deadlock on zeppelin-server

2022-04-06 Thread zhaoming.chen (Jira)
zhaoming.chen created ZEPPELIN-5711: --- Summary: Zeppelin0.10: deadlock on zeppelin-server Key: ZEPPELIN-5711 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5711 Project: Zeppelin Issue

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4336: [ZEPPELIN-5699] Trim space in ConfInterpreter

2022-04-06 Thread GitBox
Reamer commented on code in PR #4336: URL: https://github.com/apache/zeppelin/pull/4336#discussion_r844728595 ## zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/ConfInterpreter.java: ## @@ -67,6 +67,9 @@ public InterpreterResult interpret(String st, InterpreterCo