zjffdu commented on pull request #4316:
URL: https://github.com/apache/zeppelin/pull/4316#issuecomment-1077350568
@pjfanning This PR cause CI fail, I need to revert it first.
https://github.com/apache/zeppelin/actions/runs/2014897624
--
This is an automated message from the Apache Git Se
jongyoul commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1077553706
I'm just curious that this means we need to download spark manually if we
would like to use Spark Interpreter?
--
This is an automated message from the Apache Git Service.
jongyoul commented on a change in pull request #4329:
URL: https://github.com/apache/zeppelin/pull/4329#discussion_r834233403
##
File path: scalding/pom.xml
##
@@ -47,6 +47,8 @@
Concurrent Maven Repo
https://conjars.org/repo
+
+
Review comment:
I
pjfanning commented on a change in pull request #4329:
URL: https://github.com/apache/zeppelin/pull/4329#discussion_r834235219
##
File path: scalding/pom.xml
##
@@ -47,6 +47,8 @@
Concurrent Maven Repo
https://conjars.org/repo
+
+
Review comment:
jongyoul commented on a change in pull request #4329:
URL: https://github.com/apache/zeppelin/pull/4329#discussion_r834236216
##
File path: scalding/pom.xml
##
@@ -47,6 +47,8 @@
Concurrent Maven Repo
https://conjars.org/repo
+
+
Review comment:
O
zjffdu commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1077685049
@jongyoul That's right, actually the embedded spark only works in limited
functions, a lot of spark features are not available for this embedded spark.
Instead, this embedded s
jason ogaard created ZEPPELIN-5691:
--
Summary: Code completion for ipython causes exception (sometimes)
Key: ZEPPELIN-5691
URL: https://issues.apache.org/jira/browse/ZEPPELIN-5691
Project: Zeppelin
PJ Fanning created ZEPPELIN-5692:
Summary: upgrade geode-core due to cve
Key: ZEPPELIN-5692
URL: https://issues.apache.org/jira/browse/ZEPPELIN-5692
Project: Zeppelin
Issue Type: Sub-task
pjfanning opened a new pull request #4330:
URL: https://github.com/apache/zeppelin/pull/4330
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide -
https://zeppelin.apache.org/contribution/con
jongyoul commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1078416337
@zjffdu agreed. In an early stage, it was needed for expanding our community
by providing easiest way to use Zeppelin itself but thing's are changed. BTW,
we also need to cha
jongyoul commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1078589520
LGTM especially, it will help us to reduce whole build time as well.
By the way, if we forgive embedded mode, can we remove downloading python
and R as well? We will re
zjffdu commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1078610324
Good point @jongyoul let me update that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
zjffdu commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1078617276
@jongyoul After looking at the code, I realise that downloading `pyspark`
and `sparkr` can not be removed, they are required for unit test.
--
This is an automated message
jongyoul commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1078619948
> @jongyoul After looking at the code, I realise that downloading pyspark
and sparkr can not be removed, they are required for unit test.
I have an idea about it. In my
zjffdu commented on pull request #4330:
URL: https://github.com/apache/zeppelin/pull/4330#issuecomment-1078623054
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
Jeff Zhang created ZEPPELIN-5693:
Summary: IPythonInterpreterTest.testIPythonPlotting fails due to
jinjia2 version upgrade
Key: ZEPPELIN-5693
URL: https://issues.apache.org/jira/browse/ZEPPELIN-5693
P
zjffdu commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1078627564
I don't think so, we should enable user to run unit test locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
jongyoul commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1078628304
@zjffdu Yes, correct. Agreed. Then, does the download work only for testing?
I just wonder if it's possible to reduce our whole binary or not. If it can,
we'd better consider
zjffdu commented on pull request #4323:
URL: https://github.com/apache/zeppelin/pull/4323#issuecomment-1078712290
@jongyoul I mean the downloading in this maven pom.xml
(https://github.com/apache/zeppelin/blob/master/spark/interpreter/pom.xml#L355),
it is only for unit test. It won't incre
zjffdu opened a new pull request #4331:
URL: https://github.com/apache/zeppelin/pull/4331
### What is this PR for?
Specify the jinjia2 version explicitly so that we won't get the error
described in the jira.
### What type of PR is it?
[Bug Fix ]
### Todos
* [
20 matches
Mail list logo
