[GitHub] [zeppelin] Reamer commented on pull request #4252: [ZEPPELIN-5559] Add note cache

2021-11-17 Thread GitBox
Reamer commented on pull request #4252: URL: https://github.com/apache/zeppelin/pull/4252#issuecomment-971893898 @zjffdu I have changed the implementation to Read/Write-Lock and the CI is also successful. A new review would be nice. Sorry for this big change, but protecting the Note

[GitHub] [zeppelin] Reamer commented on a change in pull request #4252: [ZEPPELIN-5559] Add note cache

2021-11-17 Thread GitBox
Reamer commented on a change in pull request #4252: URL: https://github.com/apache/zeppelin/pull/4252#discussion_r751568834 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java ## @@ -391,13 +392,76 @@ public Note getNote(String noteId, boole

[GitHub] [zeppelin] Reamer commented on a change in pull request #4252: [ZEPPELIN-5559] Add note cache

2021-11-17 Thread GitBox
Reamer commented on a change in pull request #4252: URL: https://github.com/apache/zeppelin/pull/4252#discussion_r751570244 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java ## @@ -651,5 +667,63 @@ public void updateNotePath() { }