[GitHub] [zeppelin] cuspymd commented on a change in pull request #4195: [WIP][ZEPPELIN-5469]

cuspymd commented on a change in pull request #4195: URL: https://github.com/apache/zeppelin/pull/4195#discussion_r680805316 ## File path: flink/flink1.10-shims/src/main/java/org/apache/zeppelin/flink/Flink110Shims.java ## @@ -337,4 +344,27 @@ public Map extractTableConfigOpti

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4195: [WIP][ZEPPELIN-5469]

zjffdu commented on a change in pull request #4195: URL: https://github.com/apache/zeppelin/pull/4195#discussion_r680811652 ## File path: flink/flink1.10-shims/src/main/java/org/apache/zeppelin/flink/Flink110Shims.java ## @@ -337,4 +344,27 @@ public Map extractTableConfigOptio

[GitHub] [zeppelin] ebuildy commented on pull request #4192: [ZEPPELIN-5475] fix zep k8s service hostname

ebuildy commented on pull request #4192: URL: https://github.com/apache/zeppelin/pull/4192#issuecomment-891023443 Absolutely right @Reamer , in practice, I have never seen a cluster with a different search domain. Do you want me to create a config entry ? Something like ``k8s_cluste

[GitHub] [zeppelin] ebuildy edited a comment on pull request #4192: [ZEPPELIN-5475] fix zep k8s service hostname

ebuildy edited a comment on pull request #4192: URL: https://github.com/apache/zeppelin/pull/4192#issuecomment-891023443 Absolutely right @Reamer , in practice, I have never seen a cluster with a different search domain. Also, we could use only the zeppelin domain name, without the n

[GitHub] [zeppelin] zjffdu commented on pull request #4191: [ZEPPELIN-5474] Add configuration to specify the port range of shiny app

zjffdu commented on pull request #4191: URL: https://github.com/apache/zeppelin/pull/4191#issuecomment-891076083 Thanks for the review @cuspymd Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [zeppelin] zjffdu commented on pull request #4194: [ZEPPELIN-5383] add an example to the doc how to output plotly graphs

zjffdu commented on pull request #4194: URL: https://github.com/apache/zeppelin/pull/4194#issuecomment-891075627 Thanks for the review @cuspymd Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [zeppelin] zjffdu commented on pull request #4193: [ZEPPELIN-5473] Enable z.show for R

zjffdu commented on pull request #4193: URL: https://github.com/apache/zeppelin/pull/4193#issuecomment-891075897 Thanks for the review @cuspymd Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [zeppelin] zjffdu commented on pull request #4127: ZEPPELIN-5397 : Modified the interpreter.sh script to be able to parse SPARK_SUBMIT_OPTIONS

zjffdu commented on pull request #4127: URL: https://github.com/apache/zeppelin/pull/4127#issuecomment-891077363 @nilroy @Reamer If you don't mind, I will use https://github.com/apache/zeppelin/pull/4173 as short term solution for the coming release, and we can think about the long term so

[GitHub] [zeppelin] zjffdu closed pull request #4187: [ZEPPELIN-5397] Modified the interpreter.sh script to be able to parse SPARK_SUBMIT_OPTIONS

zjffdu closed pull request #4187: URL: https://github.com/apache/zeppelin/pull/4187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [zeppelin] tecgie commented on pull request #4193: [ZEPPELIN-5473] Enable z.show for R

tecgie commented on pull request #4193: URL: https://github.com/apache/zeppelin/pull/4193#issuecomment-891084233 Can you add a logic to check if the max result size is reached? If the max is reached, print out a warning message. Essentially, the same behavior as found in the python inter

[GitHub] [zeppelin] zjffdu commented on pull request #4193: [ZEPPELIN-5473] Enable z.show for R

zjffdu commented on pull request #4193: URL: https://github.com/apache/zeppelin/pull/4193#issuecomment-891087997 @tecgie Good catch, let me update it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [zeppelin] zjffdu commented on pull request #4193: [ZEPPELIN-5473] Enable z.show for R

zjffdu commented on pull request #4193: URL: https://github.com/apache/zeppelin/pull/4193#issuecomment-891494452 @tecgie PR is updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [zeppelin] zjffdu edited a comment on pull request #4193: [ZEPPELIN-5473] Enable z.show for R

zjffdu edited a comment on pull request #4193: URL: https://github.com/apache/zeppelin/pull/4193#issuecomment-891494452 @tecgie PR is updated, check the screenshot for more details -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [zeppelin] asfgit closed pull request #4191: [ZEPPELIN-5474] Add configuration to specify the port range of shiny app

asfgit closed pull request #4191: URL: https://github.com/apache/zeppelin/pull/4191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [zeppelin] zjffdu commented on pull request #4185: [ZEPPELIN-5466] Can not specify the spark image from the interpreter settings

zjffdu commented on pull request #4185: URL: https://github.com/apache/zeppelin/pull/4185#issuecomment-891498802 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [zeppelin] asfgit closed pull request #4194: [ZEPPELIN-5383] add an example to the doc how to output plotly graphs

asfgit closed pull request #4194: URL: https://github.com/apache/zeppelin/pull/4194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [zeppelin] Reamer commented on a change in pull request #4173: [ZEPPELIN-5455] Spark conf can not contain white space

Reamer commented on a change in pull request #4173: URL: https://github.com/apache/zeppelin/pull/4173#discussion_r681461670 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/launcher/SparkInterpreterLauncher.java ## @@ -106,7 +106,7 @@ public SparkIn

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4173: [ZEPPELIN-5455] Spark conf can not contain white space

zjffdu commented on a change in pull request #4173: URL: https://github.com/apache/zeppelin/pull/4173#discussion_r681474007 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/launcher/SparkInterpreterLauncher.java ## @@ -106,7 +106,7 @@ public SparkIn

[GitHub] [zeppelin] Reamer commented on pull request #4192: [ZEPPELIN-5475] fix zep k8s service hostname

Reamer commented on pull request #4192: URL: https://github.com/apache/zeppelin/pull/4192#issuecomment-891584232 > Do you want me to create a config entry ? Something like k8s_cluster_search_domain Yes, please. This is then a possible breaking change (for 1%). Please update your P