[GitHub] [zeppelin] Reamer commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.2

2021-07-20 Thread GitBox
Reamer commented on pull request #4089: URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-882361700 > @Reamer @zjffdu @prabhjyotsingh, I have updated the patch. Could you please help to review it? Thanks. I think your problems with updating the Thrift version are due to

[GitHub] [zeppelin] rickchengx commented on pull request #4176: [ZEPPELIN-5445] Allow users to access the spark UI outside the kubernetes cluster

2021-07-20 Thread GitBox
rickchengx commented on pull request #4176: URL: https://github.com/apache/zeppelin/pull/4176#issuecomment-883285849 > Please add documentation. Everything else looks good. Thanks for the comment. The documentation has been added. -- This is an automated message from the Apache Git

[GitHub] [zeppelin] rickchengx commented on pull request #4176: [ZEPPELIN-5445] Allow users to access the spark UI outside the kubernetes cluster

2021-07-20 Thread GitBox
rickchengx commented on pull request #4176: URL: https://github.com/apache/zeppelin/pull/4176#issuecomment-883285849 > Please add documentation. Everything else looks good. Thanks for the comment. The documentation has been added. -- This is an automated message from the Apache Git

[GitHub] [zeppelin] zjffdu commented on pull request #4127: ZEPPELIN-5397 : Modified the interpreter.sh script to be able to parse SPARK_SUBMIT_OPTIONS

2021-07-20 Thread GitBox
zjffdu commented on pull request #4127: URL: https://github.com/apache/zeppelin/pull/4127#issuecomment-883351876 @nilroy Any update ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4179: [ZEPPELIN-5458] fix that zepplin can not parse columns which contains chinese character

2021-07-20 Thread GitBox
zjffdu commented on a change in pull request #4179: URL: https://github.com/apache/zeppelin/pull/4179#discussion_r673609319 ## File path: livy/src/main/java/org/apache/zeppelin/livy/LivySparkSQLInterpreter.java ## @@ -197,7 +200,18 @@ public FormType getFormType() { retur

[GitHub] [zeppelin] asfgit closed pull request #4149: [ZEPPELIN-5424] Clarify LDAPRealm Bug/Limit

2021-07-20 Thread GitBox
asfgit closed pull request #4149: URL: https://github.com/apache/zeppelin/pull/4149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [zeppelin] asfgit closed pull request #4134: [ZEPPELIN-5398] fix ZEPPELIN-5398, make corrupted notes deletable

2021-07-20 Thread GitBox
asfgit closed pull request #4134: URL: https://github.com/apache/zeppelin/pull/4134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [zeppelin] zhxiaoping commented on a change in pull request #4179: [ZEPPELIN-5458] fix that zepplin can not parse columns which contains chinese character

2021-07-20 Thread GitBox
zhxiaoping commented on a change in pull request #4179: URL: https://github.com/apache/zeppelin/pull/4179#discussion_r673628437 ## File path: livy/src/main/java/org/apache/zeppelin/livy/LivySparkSQLInterpreter.java ## @@ -197,7 +200,18 @@ public FormType getFormType() { r

[GitHub] [zeppelin] zjffdu commented on pull request #4181: [ZEPPELIN-5280]. Use update as the default type of %flink.ssql

2021-07-20 Thread GitBox
zjffdu commented on pull request #4181: URL: https://github.com/apache/zeppelin/pull/4181#issuecomment-883864150 Will merge if no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [zeppelin] zjffdu commented on pull request #4181: [ZEPPELIN-5280]. Use update as the default type of %flink.ssql

2021-07-20 Thread GitBox
zjffdu commented on pull request #4181: URL: https://github.com/apache/zeppelin/pull/4181#issuecomment-883864207 Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] zjffdu commented on pull request #4180: [ZEPPELIN-5463] Introduce flink jm url template configuration

2021-07-20 Thread GitBox
zjffdu commented on pull request #4180: URL: https://github.com/apache/zeppelin/pull/4180#issuecomment-883864282 Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4179: [ZEPPELIN-5458] fix that zepplin can not parse columns which contains chinese character

2021-07-20 Thread GitBox
zjffdu commented on a change in pull request #4179: URL: https://github.com/apache/zeppelin/pull/4179#discussion_r673647395 ## File path: livy/src/main/java/org/apache/zeppelin/livy/LivySparkSQLInterpreter.java ## @@ -197,7 +200,18 @@ public FormType getFormType() { retur

[GitHub] [zeppelin] asfgit closed pull request #4171: [ZEPPELIN-5456] Allow users to set the config 'imagePullPolicy' under k8s mode

2021-07-20 Thread GitBox
asfgit closed pull request #4171: URL: https://github.com/apache/zeppelin/pull/4171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [zeppelin] zhxiaoping commented on a change in pull request #4179: [ZEPPELIN-5458] fix that zeppelin can not parse columns which contains chinese character

2021-07-20 Thread GitBox
zhxiaoping commented on a change in pull request #4179: URL: https://github.com/apache/zeppelin/pull/4179#discussion_r673677760 ## File path: livy/src/main/java/org/apache/zeppelin/livy/LivySparkSQLInterpreter.java ## @@ -197,7 +200,18 @@ public FormType getFormType() { r

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4179: [ZEPPELIN-5458] fix that zeppelin can not parse columns which contains chinese character

2021-07-20 Thread GitBox
zjffdu commented on a change in pull request #4179: URL: https://github.com/apache/zeppelin/pull/4179#discussion_r673679211 ## File path: livy/src/main/java/org/apache/zeppelin/livy/LivySparkSQLInterpreter.java ## @@ -197,7 +200,18 @@ public FormType getFormType() { retur

[GitHub] [zeppelin] zjffdu opened a new pull request #4182: Add Build profile for spark-3.1

2021-07-20 Thread GitBox
zjffdu opened a new pull request #4182: URL: https://github.com/apache/zeppelin/pull/4182 ### What is this PR for? Add maven build profile for spark 3.1. Before this PR we only have profile for spark 3.0. Besides that, this PR also did some code refactoring on spark test code.