[GitHub] [zeppelin] zjffdu commented on a change in pull request #4134: [ZEPPELIN-5398] fix ZEPPELIN-5398, make corrupted notes deletable

2021-07-09 Thread GitBox
zjffdu commented on a change in pull request #4134: URL: https://github.com/apache/zeppelin/pull/4134#discussion_r666787809 ## File path: zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java ## @@ -1007,20 +1017,29 @@ public void updatePersonalizedMod

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4134: [ZEPPELIN-5398] fix ZEPPELIN-5398, make corrupted notes deletable

2021-07-09 Thread GitBox
zjffdu commented on a change in pull request #4134: URL: https://github.com/apache/zeppelin/pull/4134#discussion_r666788283 ## File path: zeppelin-server/src/test/java/org/apache/zeppelin/service/NotebookServiceTest.java ## @@ -263,6 +264,22 @@ public void testNoteOperations()

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4134: [ZEPPELIN-5398] fix ZEPPELIN-5398, make corrupted notes deletable

2021-07-09 Thread GitBox
zjffdu commented on a change in pull request #4134: URL: https://github.com/apache/zeppelin/pull/4134#discussion_r666787809 ## File path: zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java ## @@ -1007,20 +1017,29 @@ public void updatePersonalizedMod

[GitHub] [zeppelin] zjffdu opened a new pull request #4169: [ZEPPELIN-5454] Explain output should be in text format

2021-07-09 Thread GitBox
zjffdu opened a new pull request #4169: URL: https://github.com/apache/zeppelin/pull/4169 ### What is this PR for? Use text format instead of table format for the spark sql explain statement. Because the table format is not readable. See the following screenshot. ### What typ

[GitHub] [zeppelin] zjffdu commented on pull request #4161: [ZEPPELIN-5446] SparkInterpreterLauncher#detectSparkScalaVersion may return wrong scala version

2021-07-09 Thread GitBox
zjffdu commented on pull request #4161: URL: https://github.com/apache/zeppelin/pull/4161#issuecomment-877284671 Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] Reamer commented on pull request #4161: [ZEPPELIN-5446] SparkInterpreterLauncher#detectSparkScalaVersion may return wrong scala version

2021-07-09 Thread GitBox
Reamer commented on pull request #4161: URL: https://github.com/apache/zeppelin/pull/4161#issuecomment-877574956 In my eyes, an env (environment) contains multiple values. Why do you change the variable name to envs? -- This is an automated message from the Apache Git Service. To respond