[GitHub] [zeppelin] yx91490 opened a new pull request #3340: [ZEPPELIN-4068] Implement MongoNotebookRepo

2019-03-23 Thread GitBox
yx91490 opened a new pull request #3340: [ZEPPELIN-4068] Implement MongoNotebookRepo URL: https://github.com/apache/zeppelin/pull/3340 ### What is this PR for? the format of note storage file name is changed in 0.9, this is the implementation of MongoNotebookRepo.please refer to [ZEPP

[GitHub] [zeppelin] felixcheung commented on a change in pull request #3337: [ZEPPELIN-4078] Ipython queue performance

2019-03-23 Thread GitBox
felixcheung commented on a change in pull request #3337: [ZEPPELIN-4078] Ipython queue performance URL: https://github.com/apache/zeppelin/pull/3337#discussion_r268418796 ## File path: python/src/main/resources/grpc/python/ipython_server.py ## @@ -52,24 +52,19 @@ def execu

[GitHub] [zeppelin] felixcheung commented on a change in pull request #3340: [ZEPPELIN-4068] Implement MongoNotebookRepo

2019-03-23 Thread GitBox
felixcheung commented on a change in pull request #3340: [ZEPPELIN-4068] Implement MongoNotebookRepo URL: https://github.com/apache/zeppelin/pull/3340#discussion_r268418957 ## File path: zeppelin-plugins/notebookrepo/mongo/src/main/java/org/apache/zeppelin/notebook/repo/MongoNotebo

[GitHub] [zeppelin] felixcheung commented on a change in pull request #3340: [ZEPPELIN-4068] Implement MongoNotebookRepo

2019-03-23 Thread GitBox
felixcheung commented on a change in pull request #3340: [ZEPPELIN-4068] Implement MongoNotebookRepo URL: https://github.com/apache/zeppelin/pull/3340#discussion_r268418951 ## File path: zeppelin-plugins/notebookrepo/mongo/src/main/java/org/apache/zeppelin/notebook/repo/MongoNotebo

[GitHub] [zeppelin] felixcheung commented on a change in pull request #3340: [ZEPPELIN-4068] Implement MongoNotebookRepo

2019-03-23 Thread GitBox
felixcheung commented on a change in pull request #3340: [ZEPPELIN-4068] Implement MongoNotebookRepo URL: https://github.com/apache/zeppelin/pull/3340#discussion_r268418857 ## File path: zeppelin-plugins/notebookrepo/mongo/src/main/java/org/apache/zeppelin/notebook/repo/MongoNotebo

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3340: [ZEPPELIN-4068] Implement MongoNotebookRepo

2019-03-23 Thread GitBox
zjffdu commented on a change in pull request #3340: [ZEPPELIN-4068] Implement MongoNotebookRepo URL: https://github.com/apache/zeppelin/pull/3340#discussion_r268419595 ## File path: zeppelin-plugins/notebookrepo/mongo/src/main/java/org/apache/zeppelin/notebook/repo/MongoNotebookRep

[GitHub] [zeppelin] zjffdu commented on issue #3340: [ZEPPELIN-4068] Implement MongoNotebookRepo

2019-03-23 Thread GitBox
zjffdu commented on issue #3340: [ZEPPELIN-4068] Implement MongoNotebookRepo URL: https://github.com/apache/zeppelin/pull/3340#issuecomment-475931574 Thanks @yx91490 , Could you add unit test for it ? This is an automated mess

[GitHub] [zeppelin] AyWa commented on issue #3339: [ZEPPELIN-4078] handle ipython kernel crash

2019-03-23 Thread GitBox
AyWa commented on issue #3339: [ZEPPELIN-4078] handle ipython kernel crash URL: https://github.com/apache/zeppelin/pull/3339#issuecomment-475933364 @zjffdu Hi, I just found a way to test it: https://github.com/apache/zeppelin/pull/3339/commits/f37d5f95dcaab07fdab08d9e1f03265896d02e68