[GitHub] zeppelin issue #3156: [ZEPPELIN-3610] Cluster Raft module design

2018-09-05 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3156 Thanks @liuxunorg , but the shade part does not seem correct to me. I make a simple PR to implement that. https://github.com/zjffdu/zeppelin/commit/a82dc24adace704979b866f36459df61a70d0632

[GitHub] zeppelin pull request #:

2018-09-05 Thread pityuszgege
Github user pityuszgege commented on the pull request: https://github.com/apache/zeppelin/commit/1ac0e2f0086b7da5b7149562f2db8647c3b711c9#commitcomment-30402272 In spark/interpreter/src/main/java/org/apache/zeppelin/spark/SparkSqlInterpreter.java: In spark/interpreter/src/main/ja

[GitHub] zeppelin pull request #3169: [ZEPPELIN-3689] Shade all dependencies of zeppe...

2018-09-05 Thread liuxunorg
GitHub user liuxunorg opened a pull request: https://github.com/apache/zeppelin/pull/3169 [ZEPPELIN-3689] Shade all dependencies of zeppelin-interpreter ### What is this PR for? The custom interpreter may add other dependencies which conflict with zeppelin-interpreter's dep

[GitHub] zeppelin issue #3156: [ZEPPELIN-3610] Cluster Raft module design

2018-09-05 Thread liuxunorg
Github user liuxunorg commented on the issue: https://github.com/apache/zeppelin/pull/3156 Thanks @zjffdu , This zeppelin-interpreter-api module is very much needed to solve the problem of package conflicts. I will wait for you to submit to the master. I am re-editing my code. ---

[GitHub] zeppelin issue #3169: [ZEPPELIN-3689] Shade all dependencies of zeppelin-int...

2018-09-05 Thread liuxunorg
Github user liuxunorg commented on the issue: https://github.com/apache/zeppelin/pull/3169 I saw that [zjffdu@a82dc24](https://github.com/zjffdu/zeppelin/commit/a82dc24adace704979b866f36459df61a70d0632) is already solving this problem. Maybe my pull is not needed. ---

[GitHub] zeppelin pull request #3170: ZEPPELIN-3689. Shade all dependencies of zeppel...

2018-09-05 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3170 ZEPPELIN-3689. Shade all dependencies of zeppelin-interpreter ### What is this PR for? This PR will shade all dependencies of zeppelin-interpreter, this is just to avoid the conflict with the

[GitHub] zeppelin issue #3170: ZEPPELIN-3689. Shade all dependencies of zeppelin-inte...

2018-09-05 Thread liuxunorg
Github user liuxunorg commented on the issue: https://github.com/apache/zeppelin/pull/3170 Thanks @zjffdu , This design perfectly solves the problem of dependency package conflicts. If I need to add a dependency package to zeppelin-interpreter, Is the dependency package added in t

[GitHub] zeppelin issue #3170: ZEPPELIN-3689. Shade all dependencies of zeppelin-inte...

2018-09-05 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3170 That's correct @liuxunorg ---

[GitHub] zeppelin pull request #3169: [ZEPPELIN-3689] Shade all dependencies of zeppe...

2018-09-05 Thread liuxunorg
Github user liuxunorg closed the pull request at: https://github.com/apache/zeppelin/pull/3169 ---

[GitHub] zeppelin issue #3169: [ZEPPELIN-3689] Shade all dependencies of zeppelin-int...

2018-09-05 Thread liuxunorg
Github user liuxunorg commented on the issue: https://github.com/apache/zeppelin/pull/3169 zjffdu already in [PULL-3170](https://github.com/apache/zeppelin/pull/3170) solved this problem. so I closed this pull. ---