[GitHub] [zeppelin] asfgit closed pull request #4193: [ZEPPELIN-5473] Enable z.show for R

2021-08-05 Thread GitBox
asfgit closed pull request #4193: URL: https://github.com/apache/zeppelin/pull/4193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [zeppelin] asfgit closed pull request #4193: [ZEPPELIN-5473] Enable z.show for R

2021-08-04 Thread GitBox
asfgit closed pull request #4193: URL: https://github.com/apache/zeppelin/pull/4193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [zeppelin] zjffdu commented on pull request #4193: [ZEPPELIN-5473] Enable z.show for R

2021-08-03 Thread GitBox
zjffdu commented on pull request #4193: URL: https://github.com/apache/zeppelin/pull/4193#issuecomment-892316742 Thanks for the review @tecgie will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [zeppelin] tecgie commented on pull request #4193: [ZEPPELIN-5473] Enable z.show for R

2021-08-03 Thread GitBox
tecgie commented on pull request #4193: URL: https://github.com/apache/zeppelin/pull/4193#issuecomment-891982865 Looks good. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [zeppelin] zjffdu commented on pull request #4193: [ZEPPELIN-5473] Enable z.show for R

2021-08-03 Thread GitBox
zjffdu commented on pull request #4193: URL: https://github.com/apache/zeppelin/pull/4193#issuecomment-891970969 @tecgie Thanks for the careful review, PR is updated, now I use `zeppelin.R.maxResult` to configure the max rows to display. -- This is an automated message from the Apache Gi

[GitHub] [zeppelin] tecgie commented on pull request #4193: [ZEPPELIN-5473] Enable z.show for R

2021-08-03 Thread GitBox
tecgie commented on pull request #4193: URL: https://github.com/apache/zeppelin/pull/4193#issuecomment-891919827 Thanks for the fix. Question. In zeppelin_context.py, it gets the default max_result value from the getMaxResult method of the zeppelin context. Here we have a hardcoded max

[GitHub] [zeppelin] zjffdu edited a comment on pull request #4193: [ZEPPELIN-5473] Enable z.show for R

2021-08-02 Thread GitBox
zjffdu edited a comment on pull request #4193: URL: https://github.com/apache/zeppelin/pull/4193#issuecomment-891494452 @tecgie PR is updated, check the screenshot for more details -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [zeppelin] zjffdu commented on pull request #4193: [ZEPPELIN-5473] Enable z.show for R

2021-08-02 Thread GitBox
zjffdu commented on pull request #4193: URL: https://github.com/apache/zeppelin/pull/4193#issuecomment-891494452 @tecgie PR is updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [zeppelin] zjffdu commented on pull request #4193: [ZEPPELIN-5473] Enable z.show for R

2021-08-02 Thread GitBox
zjffdu commented on pull request #4193: URL: https://github.com/apache/zeppelin/pull/4193#issuecomment-891087997 @tecgie Good catch, let me update it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [zeppelin] tecgie commented on pull request #4193: [ZEPPELIN-5473] Enable z.show for R

2021-08-02 Thread GitBox
tecgie commented on pull request #4193: URL: https://github.com/apache/zeppelin/pull/4193#issuecomment-891084233 Can you add a logic to check if the max result size is reached? If the max is reached, print out a warning message. Essentially, the same behavior as found in the python inter

[GitHub] [zeppelin] zjffdu commented on pull request #4193: [ZEPPELIN-5473] Enable z.show for R

2021-08-02 Thread GitBox
zjffdu commented on pull request #4193: URL: https://github.com/apache/zeppelin/pull/4193#issuecomment-891075897 Thanks for the review @cuspymd Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [GitHub] [zeppelin] zjffdu opened a new pull request #4193: [ZEPPELIN-5473] Enable z.show for R

2021-08-01 Thread denny wong
Can you add a logic to check if the max result size is reached?  If so, print out a warning message.  Essentially, the same behavior as found in the python interpreter.         if exceed_limit:            print("\n%html Results are limited by {}.".format(self.max_result)) ThanksDenny On S

[GitHub] [zeppelin] zjffdu opened a new pull request #4193: [ZEPPELIN-5473] Enable z.show for R

2021-07-31 Thread GitBox
zjffdu opened a new pull request #4193: URL: https://github.com/apache/zeppelin/pull/4193 ### What is this PR for? Enable `z.show` in `%r.ir` to make it consistent across languages. Unit test and docs are added. ### What type of PR is it? [Improvement] ### Todos *

Re: z.show for R

2021-07-30 Thread denny wong
. denny wong 于2021年7月29日周四 下午9:24写道: >  Here is the ticket.  It would be desirable to have this addressed soon. > Thanks. > [ZEPPELIN-5473] Enable z.show for R - ASF JIRA > > > | > | > |  | > [ZEPPELIN-5473] Enable z.show for R - ASF JIRA > > >  | > >  | >

Re: z.show for R

2021-07-30 Thread Jeff Zhang
sed soon. > Thanks. > [ZEPPELIN-5473] Enable z.show for R - ASF JIRA > > > | > | > | | > [ZEPPELIN-5473] Enable z.show for R - ASF JIRA > > > | > > | > > | > > > > > On Thursday, July 29, 2021, 08:37:56 AM EDT, Jeff Zhang < > zjf.

Re: z.show for R

2021-07-29 Thread denny wong
Here is the ticket.  It would be desirable to have this addressed soon.  Thanks. [ZEPPELIN-5473] Enable z.show for R - ASF JIRA | | | | [ZEPPELIN-5473] Enable z.show for R - ASF JIRA | | | On Thursday, July 29, 2021, 08:37:56 AM EDT, Jeff Zhang wrote: Hi Denny, Could

[jira] [Created] (ZEPPELIN-5473) Enable z.show for R

2021-07-29 Thread denny (Jira)
denny created ZEPPELIN-5473: --- Summary: Enable z.show for R Key: ZEPPELIN-5473 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5473 Project: Zeppelin Issue Type: Bug Components: r

Re: z.show for R

2021-07-29 Thread Jeff Zhang
Hi Denny, Could you create a ticket for it ? denny wong 于2021年7月29日周四 下午8:08写道: > Hi Jeff > It will be consistent to enable z.show for both python and R languages. > The zeppelin doc mentions the display system is backend independent, but it > doesn't work for R. Is it easy to enable it for R

Re: z.show for R

2021-07-29 Thread denny wong
Hi Jeff It will be consistent to enable z.show for both python and R languages.  The zeppelin doc mentions the display system is backend independent, but it doesn't work for R.  Is it easy to enable it for R? https://zeppelin.apache.org/docs/0.9.0/usage/display_system/basic.html#table Thanks De

Re: z.show for R

2021-07-28 Thread Jeff Zhang
I don't this z.show is supported in R interpreter, but you can use R package to visualize R data. denny wong 于2021年7月29日周四 上午11:03写道: > Hi > In R, we want to leverage the Zeppelin's built in visualization, but not > sure how it will work. In python, we use z.show to display a data frame > and l

z.show for R

2021-07-28 Thread denny wong
Hi In R, we want to leverage the Zeppelin's built in visualization, but not sure how it will work.  In python, we use z.show to display a data frame and leverage the built in visualization.  Is there an equivalent for R? Moreover, the table display system (%table) doesn't seem to work in R. Thank