Github user babupe commented on the issue:
https://github.com/apache/zeppelin/pull/1334
Great work guys!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user kennknowles commented on the issue:
https://github.com/apache/zeppelin/pull/1334
:+1:!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user iemejia commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@mfelgamal or @bzz you must announce this milestone in the beam mailing
list too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user iemejia commented on the issue:
https://github.com/apache/zeppelin/pull/1334
Congratulations guys, excellent work !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
Thank you so much @mfelgamal !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1334
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@bzz For me, no further discussion. looking forward to seeing the PR merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
Thank you @mfelgamal !
Merging to master, if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@bzz rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
Great, thank you @mfelgamal for great job laying foundation for Apache Beam
integration! I hate to ask but, could you please rebase it on latest master one
more time? Looks like it have diverged a bit
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@bzz @felixcheung Thank you for your reviews.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1334
LGTM other than the minor comment on static check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
Last 2 profile in CI are failing
```
[INFO] Zeppelin: Display system apis .. FAILURE [
2.537 s]
[31m- should provide onclick method *** FAILED ***[0m
[
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@felixcheung done, and now it checks if the main method is static or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@felixcheung required changes are done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@bzz Gentle reminder!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@bzz done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
CI is still failing.
Sorry for confusion, after a bit more thinking it looks like simplest way
here actually will be - to follow the same convention as with any other
interpreters, like `geo
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@bzz the changes are done, could you take a look at pom file and CI ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@mfelgamal to address 1-2 can you please try to update `.travis.yml`: `-pl
\!beam` -> `-pl !beam` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
Looks great to me, thank you @mfelgamal !
I think it's ready to be merged.
The only minor thing that looks a bit off - re-formatted `pom.xml` is not
consistent with the other modules,
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@bzz all required changes are done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
After running it locally, I think it is great but the last thing that would
be very nice to have, is to expand the example in the docs to be
self-contained, meaning easily runnable by the the first-ti
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
I think having it as it is now sounds as a good start. It can be always
enhanced it later on, based on user feedback.
Changes look great to me, thank you!
If that is ok - please let m
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@bzz The following updates are made:
1 - Updating beam version from 0.1 to 0.2
2 - License report is updated for all dependencies
Regarding point #2 in the previous message, do y
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@bzz kindly be noted for point # 2:
Making user do minimal amount of code is good but the only cons is that the
user will be given the default implementations and configurations and can not
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
Few questions after another pass:
1. Right now Beam interpreter uses **Beam version 0.1.0-incubating**, but
didn't Beam project release 0.2.0-incubating on 2016-08-09? Do you think it
would
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@bzz rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@mfelgamal thank you for kind reminder! Will try it more today and get back
to you asap.
Meanwhile, it looks like it needs to be rebased on latest master.
---
If your project is set up for i
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@bzz Gentle reminder!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@mfelgamal Thank you! Please let me look into CI and get back to you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@AhyoungRyu the changes is done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@bzz I updated `.travis.yml` and there is an error while building `Could
not find the selected project in the reactor: '!beam'` but the command `-pl
'!beam'` run on local without any error.
--
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
> It seems that your builder enforces the usage of Scala 2.11
@mfelgamal you are right, `.travis.yml` contains Scala 2.11 as well as
scala 2.10 profiles.
In this case, could you please e
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@felixcheung the requied changes is done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1334
Let's make sure the new doc is added to the list in _navigation.html?
https://zeppelin.apache.org/docs/0.6.1/development/writingzeppelininterpreter.html#contributing-a-new-interpreter-to-ze
Github user iemejia commented on the issue:
https://github.com/apache/zeppelin/pull/1334
Oups I forgot the second comment, I don't know if it is also worth to
separate every runner as a different interpreter (leaving probably the
DirectRunner as the default Beam one). And having the o
Github user iemejia commented on the issue:
https://github.com/apache/zeppelin/pull/1334
Good work guys, probably this is the one other approach I missed in the
JIRA, to have a static repl to compile the full class and then run it, this is
nice because this can be reused for any full
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@bzz Kindly be noted that there is no maven Scala 2.11 build for beam
runner Flink. The only available build is beam-runners-flink_2.10 .
https://mvnrepository.com/artifact/org.apache.beam/b
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
Before proceed with review - I have noticed that CI is failing.
@mfelgamal could you please take a look and make sure that there are no
Beam-related failures? Thanks!
So far there is
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
Thank you for addressing the feedback promptly! Please let me take another
pass on it and get back to you here.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@bzz The required changes is done, in the recent commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
Thank you for contributing @mfelgamal ! Apache Beam interpreter is a
valuable contribution many people are looking for.
There are few things that need to be done before we can merge it though:
GitHub user mfelgamal opened a pull request:
https://github.com/apache/zeppelin/pull/1334
[ZEPPELIN-682] New interpreter for Apache Beam (incubating)/DataFlow
## What is this PR for?
The PR is a interpreter for [Apache Beam](http://beam.incubator.apache.org)
which is an open
ion?
>> >
>> > [1] https://github.com/albertlatacz/java-repl
>> >
>> > On Fri, Jun 3, 2016 at 3:23 PM, Felix Cheung > >
>> > wrote:
>> >
>> > > Absolutely! We would welcome your contribution for this!
>> > >
>> >
; > wrote:
> >
> > > Absolutely! We would welcome your contribution for this!
> > >
> > >
> > >
> > > _
> > > From: Minudika Malshan
> > > Sent: Monday, May 30, 2016 9:2
b.com/albertlatacz/java-repl
>
> On Fri, Jun 3, 2016 at 3:23 PM, Felix Cheung
> wrote:
>
> > Absolutely! We would welcome your contribution for this!
> >
> >
> >
> > _
> > From: Minudika Malshan
> > Se
gt; From: Minudika Malshan
> Sent: Monday, May 30, 2016 9:24 PM
> Subject: Re: ZEPPELIN-682
> To: Alexander Bezzubov
> Cc:
>
>
> Hi all,
>
> Seems like this project is going to be taken care of. I submitted two
> proposals for gsoc and the other proposal got accepte
Absolutely! We would welcome your contribution for this!
_
From: Minudika Malshan
Sent: Monday, May 30, 2016 9:24 PM
Subject: Re: ZEPPELIN-682
To: Alexander Bezzubov
Cc:
Hi all,
Seems like this project is going to be taken care of. I submitted
Hello,
Yes, I am actually working on this, and I proposed a first roadmap in a
previous email:
https://lists.apache.org/thread.html/Zfq3cpnr55obgrs
Notice that the first point is more on the scala/spark integration front,
and we need two things, to use scio as an scala API/REPL for Beam (to be
i
Hi all,
I was going to do this project for GSOC 2016. I submitted two proposals for
gsoc and the other proposal got accepted.
However I'm more than happy to contribute for this project.
I would like to know if there's anyone already working on this
implementation.
Thanks
Minudika
Hi all,
Seems like this project is going to be taken care of. I submitted two
proposals for gsoc and the other proposal got accepted.
However I'm more than happy to contribute for this project.
Please let me know if there's anything I can do.
Thanks
Minidika
On Mar 25, 2016 10:53 AM, "Alexande
52 matches
Mail list logo
