Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
@onkarshedge thank you for the great work!
How do you think, how hard it would be to rebase it on latest master?
---
If your project is set up for it, you can reply to this email and have your
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/989
in a sense i agree with @corneadoug and i'll write more details on that
later, but for the beginning wouldn't it make sense to save normal notes
without commit in ipfs as well?
---
If your
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/989
Considering https://github.com/apache/zeppelin/pull/1304 is the import
really needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/989
I'm a bit lost with this feature, is it really considered as a NotebookRepo
or does it only keep the revisions? Does importing the Hash mean that it import
a Revision as Notebook?
Why d
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
Looks great, @onkarshedge! I posted a few comments above.
\cc @khalidhuseynov for extra back-end code review and @corneadoug for
front-end one
---
If your project is set up for it, you can re
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/989
@bzz CI is green please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/989
@bzz I found this
[documentation](http://docs.ipfs.apiary.io/#reference/version/version/version)
and there would be no need for dependency. I have used apache-httpcomponents
httpclient.
---
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
@onkarshedge so you say it's not published on Maven Central?
According to ipfs/java-ipfs-api#1 there is an option fetch it from
`https://jitpack.io`. Can you please add new repository to `pom.
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/989
@corneadoug feedback addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/989
@bzz there are no transitive dependencies, just Junit and hamcrest
The reason of CI failure is
>[ERROR] Failed to execute goal on project zeppelin-zengine: Could not
resolve depend
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
@onkarshedge great progress, thank you for keeping us posted!
Before moving further, on top of great suggestions from @corneadoug, there
are few more things you also need to take care of:
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/989
@onkarshedge I would need a scenario/setup to be able to test it, could you
add it to the PR description?
Regarding the timeout function in front-end, I think it would be better to
send back
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/989
@bzz @corneadoug please review,it is complete. I have added the screenshot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
@onkarshedge what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/989
@onkarshedge just like @bzz said, it would be better to have that import
function in the back-end.
This is the [PR](https://github.com/apache/zeppelin/pull/374) that first
implemented the fe
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
Do you want to do that on the client-side, right in the browser?
I see what you mean - our existing impor function indeed fetches from URL
and parse JSON right in the browser, but I do not thi
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/989
@bzz To import the note by hash url . I will have to use
[javascript-api](https://github.com/ipfs/js-ipfs-api) in this
[notenameImport.controller.js](https://github.com/apache/zeppelin/blob/mas
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
ping @onkarshedge
Could you please follow
https://github.com/apache/zeppelin/pull/989#issuecomment-230972882 and update
this PR
---
If your project is set up for it, you can reply to
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
Got it, thanks! Please submit another WIP pr with Bittorents support.
Could you still follow
https://github.com/apache/zeppelin/pull/989#issuecomment-230972882 and update
this PR as soon as yo
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/989
@bzz right now I am working on Bittorrent support. I am using the
[jlibtorrent](https://github.com/frostwire/frostwire-jlibtorrent) which uses
libtorrent. The past week I spent time on using th
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
ping, @onkarshedge are there any updates for the past week?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
@onkarshedge sorry, people were busy releasing 0.6.0 recently
Could you please:
- [ ] rebase this code on latest `master` branch
- [ ] update title (add WIP) and PR description to cont
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
Thank you very much @onkarshedge ! I will go though it and let you know
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/989
@bzz Here is the link to document for first question.
[High level
description](https://docs.google.com/document/d/1OZOowc6aX3BrRkgjkUKwD19DshNXMWE2M07LMpXepx4/edit?usp=sharing)
TODO's is
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
Hi @onkarshedge, as mid-term evaluation starts soon, I think it's crucial
to get answers on 2 previous questions now.
>Could you also point to some document with high-level description of the
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/989
Should i save to Filesystem like `VFSNotebookRepo` and only when user
chooses to version it add it to ipfs that way the ipfs will contain only the
ipfs object corresponding to versioned notes a
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/989
@bzz I had a doubt about versioning approach.
Currently I am saving(ipfs add 'note') the note in IPFS for every call to
save function. This gives me a new multihash on saving. So for version
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
@onkarshedge I understand that it's WIP, just wanted to remind that
eventually your `NotebookRepo` implementation should user
`NotebookRepoVersioned`, see Git one as an example.
Could you also
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/989
@bzz please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/989
@bzz please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user onkarshedge commented on the issue:
https://github.com/apache/zeppelin/pull/989
@bzz Please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
31 matches
Mail list logo
