[GitHub] zeppelin issue #3068: [ZEPPELIN-3438] Passing Z variables to BigQuery

2018-07-17 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3068 We won't enable it for all interpreters. By default we could disable it, interpreter can enable it via setting `zeppelin.interpreter.interpolation` to `true` to enable it. The purpose is just to pr

[GitHub] zeppelin issue #3068: [ZEPPELIN-3438] Passing Z variables to BigQuery

2018-07-17 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3068 do we really need this for all interpreters though? for those we don't have active maintainer it might better not to change them ---

[GitHub] zeppelin issue #3068: [ZEPPELIN-3438] Passing Z variables to BigQuery

2018-07-16 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3068 This is a great idea @zjffdu. There are also a few other things to think of - like automatically generating the name of the enabler parameter on a per-interpreter basis (`zeppelin

[GitHub] zeppelin issue #3068: [ZEPPELIN-3438] Passing Z variables to BigQuery

2018-07-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3068 Thanks @sanjaydasgupta I was thinking whether we could do it in Interpreter.java like this. ``` public abstract InterpreterResult interpret2(String st,

[GitHub] zeppelin issue #3068: [ZEPPELIN-3438] Passing Z variables to BigQuery

2018-07-16 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3068 Thanks for the suggestion @zjffdu. The same idea was given earlier by Leemoonsoo [here](https://github.com/apache/zeppelin/pull/2502#issuecomment-323272122), and I had then [moved

[GitHub] zeppelin issue #3068: [ZEPPELIN-3438] Passing Z variables to BigQuery

2018-07-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3068 @sanjaydasgupta I was thinking would it better to put it in Interpreter base class instead of doing it in every interpreter implementation. ---

[GitHub] zeppelin issue #3068: [ZEPPELIN-3438] Passing Z variables to BigQuery

2018-07-15 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3068 The two failed tests on travis - apparently unrelated to the code from this PR - are really stubborn and wont go away no matter what I do! ---

[GitHub] zeppelin issue #3068: [ZEPPELIN-3438] Passing Z variables to BigQuery

2018-07-15 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/3068 Thanks for pointing out the issue @felixcheung I've corrected the link as well as some of the preceding words as the ZeppelinContext documentation is now in its own page - not unde

[GitHub] zeppelin issue #3068: [ZEPPELIN-3438] Passing Z variables to BigQuery

2018-07-13 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3068 LGTM ---