[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3039 Thanks for review, will merge if no more comments ---

[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3039 @zjffdu Thanks for explaining. I thought it could change all of the properties by this settings. ---

[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3039 No,this is not this ticket's purpose. If user want to change interpreter level properties, they need inline conf interpreter. This ticket is to allow customize paragraph level behavior, e.g. pool

[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3039 In my guess, you might want to change some spark properties with executing Spark paragraph. In this case, we might need to restart SparkInterpreter to adopt some properties like `spark.executor.m

[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3039 Sorry @jongyoul I don't understand that. Why do you think it would affect restarting interpreters ? Do you have any more detail examples ? ---

[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3039 Hi, basically, parsing properties with every execution may not affect much in performance on interpreter side. But It might affect the behaviours of restarting interpreters. e. g. every restartin

[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3039 Specifically in this PR, LGTM though ---

[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3039 Thanks @mebelousov for the feedback. We could do that in a followup PR to improve user friendliness. Because currently I can not imagine in what kind scenario user would add lots of parameters. I

[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3039 @zjffdu great powerful feature! When the parameters will be a lot, it will be not easy to find and write the parameter name. I wish it would be more user-friendly with drop-down panel. A

[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-21 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3039 @Leemoonsoo @prabhjyotsingh @felixcheung @jongyoul Could you help review it ? Thanks ---