Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
Cleaning the cache helped. Thanks for the hint @zjffdu
All green now @jongyoul
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3000
@sanjaydasgupta If you see the following error in travis build. Please
clean travis cache first, then retrigger the build.
```
[ERROR] error: error while loading , error in opening zip
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
Hi @jongyoul one test is still red. I have restarted it 3 times, but it has
failed with the same result each time. Please let me know if there is anything
else to try.
---
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3000
Thanks. BTW, please check your CI and restart the failed ones
https://travis-ci.org/sanjaydasgupta/zeppelin/builds/401742347
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
@jongyoul please ignore my previous comments (now deleted)
The rebase has been done.
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
@jongyoul the merge occurred by mistake, and I am not being able to revert
it using the `git revert -m 1 ` command.
I've tried looking up all help on the net, but am not getting an
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3000
@sanjaydasgupta Could you please rebase this PR from the current master?
merging master results as same but it's not human readable.
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
I've fixed the style issues pointed out.
One test still fails on travis--despite a rebase and restart. But the
failure seems unrelated to the changes made in this PR.
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
Have fixed the style issues @felixcheung.
One of the tests is failing--despite rebase and restart--but appears to be
unrelated to the code change.
---
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3000
LGTM
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
ping @felixcheung
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3000
> The orphaned file will not be automatically overwritten later because
File.createTempFile(...) will always attempt to create a new filename that is
unused in the directory.
That makes now
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
@Tagar thanks for your comments.
The thought here was to make the best of a bad situation. If and when the
`delete()` fails, no recovery action is possible at the user level. So the
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
Agreed @zjffdu.
I also made two other (similar) changes. If the `tempFile.delete()` fails,
then `tempFile.deleteOnExit()` is invoked to request the system to handle it if
possible
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3000
One minor comment, rest LGTM
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3000
@zjffdu
---
16 matches
Mail list logo
