Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2700
LGTM, will merge if no more comments
---
Github user nighthawk6389 commented on the issue:
https://github.com/apache/zeppelin/pull/2700
Would love to see this merged!
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2700
It is awsome if there's such button. But I don't know how to make such
button. BTW usually I would force push a dummy commit to trigger the build. And
I believe we should also fix these flaky test
Github user mohamagdy commented on the issue:
https://github.com/apache/zeppelin/pull/2700
@zjffdu all good. I closed and reopened the pull request.
I would suggest making the process of rerunning Jenkins easier than closing
and reopening the pull request. This also triggers T
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2700
ping @mohamagdy
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2700
@mohamagdy could you check - there are a bunch of errors
https://travis-ci.org/mohamagdy/zeppelin/builds/324495310
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2700
looks like Jenkins has lost the test run result - could you kick that off
again? you can do that by closing and reopening this PR.
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2700
and we should probably check why RAT doesn't pick up the missing ASF header
for new files?
---
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2700
Can you restart some failed job on
https://travis-ci.org/mohamagdy/zeppelin/builds/317797015 ?
---
Github user mohamagdy commented on the issue:
https://github.com/apache/zeppelin/pull/2700
@Leemoonsoo, thanks a lot for reviewing and testing the branch.
I will fix the Jenkins job with the information you provided.
Regarding the test files, the tests for the `GitNote
Github user mohamagdy commented on the issue:
https://github.com/apache/zeppelin/pull/2700
@felixcheung, the `GitHubNotebookRepo` inherits from `GitNotebookRepo` but
the difference is, after the notebook is saved (and committed), the
`GitHubNotebookRepo` updates (pushes the local comm
11 matches
Mail list logo
