Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2668
Any more comments ? I will merge if no more comments.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2668
@felixcheung I added `bin/stop-interpreter.sh` so that user can force kill
interpreter process even when recovery is enabled.
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2668
Yes!
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2668
There's no way to shutdown everything when `zeppelin.recovery.enabled` is
true. Are you concerning orphan process ?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2668
@Leemoonsoo Just find out that zeppelin didn't capture the correct pid of
interpreter process, it capture the parent process of interpreter process
(interpreter.sh) instead of the jvm process. I fi
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2668
oops, didn't notice `zeppelin-daemon.sh` will also kill interpreter
process, but according my expereince, it seems `zeppelin-daemon.sh` won't kill
interpreter process, let me double check that.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2668
Correct me if i'm wrong.
https://github.com/apache/zeppelin/pull/2668/files#diff-3477d79f3012453f20c3727ec60338e9R230
skips interpreter close when `zeppelin.recovery.enabled` is true. However,
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2668
@Leemoonsoo Recovery feature is controlled `zeppelin.recovery.enabled` by
in zeppelin-site.xml, if it is enabled, interpreter process won't be killed.
see
https://github.com/apache/zeppelin/pu
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2668
Doesn't
https://github.com/apache/zeppelin/blob/master/bin/zeppelin-daemon.sh#L222 need
to aware of recovery? Otherwise, it terminates all the interpreters on
`zeppelin-deamon.sh stop`
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2668
@felixcheung @Leemoonsoo @jongyoul Any more comments ?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2668
Currently, there's no api for restarting interpreter process. Restarting
interpreter setting just terminate interpreter process, and will restart
interpreter process when user run paragraph.
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2668
Is there a way to restart the interpreter process?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2668
```
is there such a way to force restart?
```
Sorry, @felixcheung , I didn't get you, can you explain it more ?
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2668
I see. I think I see close/restarting the process as a last-ditch effort to
get around issue with the JVM; is there such a way to force restart?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2668
Closing `InterpreterSettingManager` is for shutting down interpreter
processes, otherwise we would get dangling processes. There's no other side
effect.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2668
@Leemoonsoo @jongyoul @felixcheung @prabhjyotsingh Could you help review
it ? Thanks
---
16 matches
Mail list logo