Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2630
Yes, I know the current situation and this PR solves what kind of problem,
but our merge script uses squash merge from PR branch and it means if that PR
branch has `property` in that branch, it w
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2630
@jongyoul
this branch has no conflicts with branch master. In CI all ok, because
branch of PR has field property. After merge jobs falls (CI, branch master)
https://travis-ci.org/apache/z
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2630
Yes, what I wondered is how that PR passed our CI. `property` doesn't exist
in the class and it shouldn't have passed CI. May we have a hole on our CI?
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2630
@jongyoul @zjffdu
after merge https://github.com/apache/zeppelin/pull/2596
https://github.com/apache/zeppelin/pull/2596/files#diff-dbda0c4083ad9c59ff05f0273b5e760fR935
`proper
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2630
Iâm also curious about it. Itâs very basic error when compiling without
symbol.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2630
Thanks @tinkoff-dwh for fixing this. Could you let me know how
SparkRInterpreter is broken, I am curious to know why our CI didn't catch this.
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2630
Ok thanks for fixing this.
---
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2630
LGTM. I'll merge it as a hotfix. BTW, I think it would be better to divide
two different PR by fixing bug and refactoring somethings.
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2630
@necosta @zjffdu @felixcheung
pls help with review
---
