[GitHub] zeppelin issue #2554: [ZEPPELIN-2627] Interpreter Component Refactoring

Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2554 Sure here you go [ZEPPELIN-3029](https://issues.apache.org/jira/browse/ZEPPELIN-3029) ---

[GitHub] zeppelin issue #2554: [ZEPPELIN-2627] Interpreter Component Refactoring

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2554 hmm, I see. Because every time I will merge interpreter-setting.json into interpreter-setting.json. Mind to create a ticket ? I will fix it. ---

[GitHub] zeppelin issue #2554: [ZEPPELIN-2627] Interpreter Component Refactoring

Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2554 @zjffdu Just found out an issue which is a side effect of this PR, now I cannot delete an interpreter. By that what I mean is now say if I delete angular interpreter from the interpre

[GitHub] zeppelin issue #2554: [ZEPPELIN-2627] Interpreter Component Refactoring

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2554 Thanks @Leemoonsoo for the review, I will merge it if no more comments. And will do the change in the following PR as there's still remaining work for the refactoring. --- If your project is set

[GitHub] zeppelin issue #2554: [ZEPPELIN-2627] Interpreter Component Refactoring

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2554 Thanks @zjffdu for great work. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] zeppelin issue #2554: [ZEPPELIN-2627] Interpreter Component Refactoring

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2554 Let me test this branch little more with some edge cases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] zeppelin issue #2554: [ZEPPELIN-2627] Interpreter Component Refactoring

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2554 @Leemoonsoo Do you mind if I commit it first to continue other works ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] zeppelin issue #2554: [ZEPPELIN-2627] Interpreter Component Refactoring

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2554 @Leemoonsoo I add more comments for the test case. Some testcase is not needed any more --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] zeppelin issue #2554: [ZEPPELIN-2627] Interpreter Component Refactoring

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2554 I can see some test cases are removed or commented out. for example zeppelin-zengine/src/test/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterTest.java and some other places.