[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

2017-11-15 Thread yu74n
Github user yu74n commented on the issue: https://github.com/apache/zeppelin/pull/2525 Close this PR because Continued at #2585 ---

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

2017-09-08 Thread yu74n
Github user yu74n commented on the issue: https://github.com/apache/zeppelin/pull/2525 After fixed 'testSyncWithAcl', I manually restart CI. All test passed. ---

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

2017-09-07 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2525 @yu74n Thanks for the update. Could u restart / check the failed job? https://travis-ci.org/yu74n/zeppelin/jobs/273160145 ---

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

2017-09-07 Thread yu74n
Github user yu74n commented on the issue: https://github.com/apache/zeppelin/pull/2525 I've fixed failed unit tests. ---

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

2017-08-31 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2525 Let me check public and private modes and reply as well. Seems that CI constantly fails. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

2017-08-24 Thread yu74n
Github user yu74n commented on the issue: https://github.com/apache/zeppelin/pull/2525 One more thing. Should we set admin role to notebook owner in public mode? I'm going to change this feature to set admin role to notebook owner, reader and writer in private mode though. --- If y

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

2017-08-24 Thread yu74n
Github user yu74n commented on the issue: https://github.com/apache/zeppelin/pull/2525 @1ambda thx @felixcheung You are right, this feature affects all modes(private and public). I don't understand public mode in detail, is there any problem if we set admin role in public mode? Sh

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

2017-08-24 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2525 @yu74n Could you solve the conflict and reply @felixcheung's last comment? > but seems like this isn't just default owner/admin for private mode only, but in all cases? --- If your proje

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

2017-08-24 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2525 I think this feature is useful. That's because admin can't see all notes currently - since they not owner even if admin has `admin` role. - so admin needs to ask all notebook creator

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

2017-08-13 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2525 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

2017-08-11 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2525 I think so. If we add admin when creating, it would be better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe