Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2506
@1ambda what do you think?
Merge to master if no further discussions
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2506
@1ambda
what about new UI?
---
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2506
Tried this branch and it works really well
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2506
@1ambda
Restyling done.
New UI:
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2506
The one of famous product what does the same thing with this PR is Source
Tree as u know. And it has this kind of UI. I think @tinkoff-dwh you can get
ideas from this UI
 header contains comboboxes for choice commit and combobox with mode of
diff
- side-by-side paragraph
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2506
For me, it's up to you.
- keep current implementation
- try and propose few different UIs
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2506
@1ambda
I mean, it is not clear what to do, wait for other reviews or to do
something (but then it is not clear what)
---
If your project is set up for it, you can reply to this email an
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2506
I didn't mean both. Just gave an opinion.
Personally, I don't believe that reviewer only can reply `LGTM` or `NO`.
---
If your project is set up for it, you can reply to this email and have yo
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2506
@1ambda
is it "LGTM" or no?) ' we can get improved UI' sounds unclear)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2506
@tinkoff-dwh Thanks for the update.
In feature and code level, it's good. But personally, I hope we can get
improved UI.
---
If your project is set up for it, you can reply to this email
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2506
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2506
@1ambda
fixed
---
If your project is set up for it, you can reply
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2506
regarding UX,
- `Choose` box is too big compared to the text inside
- It would be nice to have the list-like view for each item. For example,
 and now rewritten for a long time as it is necessary to rewrite
all the layout
---
If your
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2506
@tinkoff-dwh It looks great. One suggestion is that is it possible to show
the revision comparison inline instead of popping up a new window. Because I
think we can some followup work for this fea
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2506
re: doc - I see what you mean. I think it'll be great to have doc on
import/export, and this, maybe like
https://zeppelin.apache.org/docs/0.7.2/manual/notebookashomepage.html
---
If your pro
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2506
+1 to that
https://github.com/apache/zeppelin/pull/2506#pullrequestreview-53385386
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2506
@felixcheung
https://github.com/apache/zeppelin/tree/master/docs/quickstart here?
i don't know. I think this is not such a difficult thing to write in
documentation...
---
If yo
Github user sravan-s commented on the issue:
https://github.com/apache/zeppelin/pull/2506
Tested this PR, worked fine. Nice addition ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2506
@zjffdu done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2506
@tinkoff-dwh Do you mind to attach a gif for easy review ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
24 matches
Mail list logo
