[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-19 Thread ebuildy
Github user ebuildy commented on the issue: https://github.com/apache/zeppelin/pull/2458 I don't know why Jenkins is red, Travis is all green => https://travis-ci.org/ebuildy/zeppelin --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-16 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2458 CI is green, I think jenkins was restarted somehow. - https://travis-ci.org/ebuildy/zeppelin/builds/253975556 LGTM merge if no more discussion. --- If your project is set up for

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-16 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 @ebuildy could you check CI? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-16 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 Tested and LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-14 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2458 @ebuildy I left a comment. Could u check that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-13 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2458 @ebuildy Thanks for the contribution. Tested and works well, merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-13 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 Thanks a lots :slightly_smiling_face: Let me test it out again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-13 Thread ebuildy
Github user ebuildy commented on the issue: https://github.com/apache/zeppelin/pull/2458 Nop sorry, this is very good suggestions, I was at Berlin for work, I am doing this now! Thanks you, --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-13 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 Hey, @ebuildy! If you don't want to improve my suggestion(#2458 (comment)), please let us know so that we will start merge process, I guess. --- If your project is set up for it, you can repl

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-10 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 I tested this one and it looks better than before, except above a my comment about CI failure. And I suggest one thing. in this chance, how about changing landing page name from `localhost:808

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-05 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 Could you remove the `{{ $root.pageTitle }}` word when loading page like this? ![title](https://user-images.githubusercontent.com/8110458/27855590-fdc1a76c-61a5-11e7-9940-028ae2c60597.gif)

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-04 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 Oh, It's great! Let me test it out as soon as possible. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-04 Thread ebuildy
Github user ebuildy commented on the issue: https://github.com/apache/zeppelin/pull/2458 Yeah all green now! (https://travis-ci.org/ebuildy/zeppelin/builds/249550322) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-04 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 Ah, you don't mind those lines because your 1.8 job became green light! So, I think that it would be nice to run again about 1.3 and 1.5 jobs. Could you try again, please? --- If your proj

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-04 Thread ebuildy
Github user ebuildy commented on the issue: https://github.com/apache/zeppelin/pull/2458 I don't know why it fails here: https://travis-ci.org/ebuildy/zeppelin/jobs/249550330#L776 ``ERROR org.apache.zeppelin.spark.SparkVersion:63 - Can not recognize Spark version DEV-

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-04 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 You're welcome! Yeah, the current Travis is not good but it's working. If when your Travis become green or it is fail but it is not related your PR, I can test it out (: --- If your pr

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-04 Thread ebuildy
Github user ebuildy commented on the issue: https://github.com/apache/zeppelin/pull/2458 Ya I think it complains about https://travis-ci.org/ebuildy/zeppelin , some jobs have failed, I am checking it. thanks you. --- If your project is set up for it, you can reply to this email and h

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-03 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 Hi, @ebuildy. Thanks for improving it. But Travis is fail, could you check this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well