Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Need rework.
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2449
@Leemoonsoo, @felixcheung, @zjffdu I think it's good to go.
Any concerns about backend code like persistency, ...?
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2449
LGTM!
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review (red for other tests )
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
@1ambda @zjffdu
Thank you for your comments. Classes have been renamed to match its
functionality
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2449
I think we have a comment thread on this PR
https://github.com/apache/zeppelin/pull/2449#discussion_r127705438
---
If your project is set up for it, you can reply to this email and have y
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2449
@1ambda
Number of recent is limited: `MAX_RECENT_SIZE = 10`
(https://github.com/apache/zeppelin/pull/2449/files#diff-289945053c8adc894aa4838564528ba5)
Place `Recent` before `Notebook`:
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2449
I have a suggestion.
- Place `Recent` before `Notebook` (more upper side)
- Limit the maximum number of recent notebooks.
That's because users are accessing recent notebook mor
22 matches
Mail list logo
