[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2440 Hi folks, Please let me know if I should close this. Tks! ---

[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2440 This is now passing all tests - please advise --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2440 hmm I'm finding it difficult to get all the integration tests to pass. Inclined to test only for the presence of the button. --- If your project is set up for it, you can reply to this email and h

[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2440 @herval 1. Could you rebase? base branch is quite old 2. We need to pass CI. Please the failed tests. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2440 @1ambda can you check this issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2440 any additional thoughts on this? Is it mergeable? @jongyoul @cfries --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2440 I got it. I didn't recognize actual username is "anonymous" in production case. If it can be, it will be a problem. --- If your project is set up for it, you can reply to this email and have you

[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

Github user cfries commented on the issue: https://github.com/apache/zeppelin/pull/2440 Hi @jongyoul : I don't understand your comment. You can have "anonymous" when shirt is on. This is even in the shiro example (note: If I understood the shiro example correctly: until the user is no

[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2440 I don't know the purpose of this PR. If username is anonymous, it means shiro is off. What's your intention? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2440 @zjffdu added one, let me know if that covers it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2440 Could we add a simple selenium test for this ? Regression issue is bad thing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo