[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2018-09-03 Thread bern80
Github user bern80 commented on the issue: https://github.com/apache/zeppelin/pull/2439 Dear All, Is this _zeppelin-web/src/app/notebook/paragraph/result/result.controller.js_ script already fixed on master branch? Thanks, R. ---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2018-02-22 Thread weand
Github user weand commented on the issue: https://github.com/apache/zeppelin/pull/2439 @herval: I merged latest master: [https://github.com/weand/zeppelin/tree/ZEPPELIN-2680](https://github.com/weand/zeppelin/tree/ZEPPELIN-2680) But I also face continuous requests against heli

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2018-02-19 Thread weand
Github user weand commented on the issue: https://github.com/apache/zeppelin/pull/2439 @herval would you mind merging again on latest master? @soralee @zjffdu as we face the same issue, and we are using helium, I will also test it. ---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-09-07 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 Hi folks, Please let me know if I should close this. Tks! ---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-24 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 @soralee @khalidhuseynov would you or anyone else like to give this a new try? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-13 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 hmm I'll see if I can somehow split "report mode" and "view only mode". I didnt experience the Helium issue, personally --- If your project is set up for it, you can reply to this email an

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-12 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2439 thanks for the improvement, this scenario needs to be fixed indeed. after trying the pr, i noticed couple of things * when following scenario and going into note as user2, my browser go

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-11 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 all tests passing now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-11 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2439 Tested and LGTM! It looks cool that when a `writers` logins a note, it shows report mode. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-11 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2439 Good! Let me test it out agian! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-10 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 Ok, retested now and it's working as expected. If you need to login (using anonymous mode support), you may need this PR first: https://github.com/apache/zeppelin/pull/2440 --- If your pr

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-05 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2439 I just checked again, but there is still a same problem. could you check this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-04 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2439 Yes, I did. I run `mvn clean package -DskipTests` I'll check again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-04 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 Hmm I’ll try again. Btw, did you `mvn clean` after switching branches? I think changes on the js/html files don’t get picked up unless you do that... __

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-04 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2439 I could reproduce this problem on master branch but, I could not see to resolve on your branch. It has same error. Could you test it out on your branch? --- If your project is set up for

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-03 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2439 Oh, Thanks for quick answer and check! Let me test as your comment and come back here! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-03 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 @soralee thanks for taking the time :-) there's one more step to your list: 1. login as user1 2. create a note 3. add a paragraph **4. change the visualization to a chart (instea

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-03 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2439 I have a question quickly. For reproduce, I just make sure test flow clearly. 1. login as user1 2. create a note 3. add a paragraph 4. set `owners` and `writers` field set user1

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-03 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2439 Hi, @herval. Thanks for contribution and sorry for late response. Let me take a look this one. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-03 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 any thoughts on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-06-28 Thread herval
Github user herval commented on the issue: https://github.com/apache/zeppelin/pull/2439 Build is green: https://travis-ci.org/herval/zeppelin/builds/247345573 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec