[GitHub] zeppelin issue #2435: [ZEPPELIN-2688]. Upgrade ace to 1.2.7

2017-06-28 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2435 oh nice --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #2435: [ZEPPELIN-2688]. Upgrade ace to 1.2.7

2017-06-28 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2435 Will merge it if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] zeppelin issue #2435: [ZEPPELIN-2688]. Upgrade ace to 1.2.7

2017-06-27 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2435 Thanks for review @1ambda --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] zeppelin issue #2435: [ZEPPELIN-2688]. Upgrade ace to 1.2.7

2017-06-27 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2435 Tested locally and works well. ![image](https://user-images.githubusercontent.com/4968473/27584400-df1bd762-5b72-11e7-8bac-2ee577c01a1c.png) Here is a comparison between two versio

[GitHub] zeppelin issue #2435: [ZEPPELIN-2688]. Upgrade ace to 1.2.7

2017-06-27 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2435 Let me review and comment soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] zeppelin issue #2435: [ZEPPELIN-2688]. Upgrade ace to 1.2.7

2017-06-26 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2435 @1ambda @minahlee Could you help review it ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] zeppelin issue #2435: [ZEPPELIN-2688]. Upgrade ace to 1.2.7

2017-06-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2435 @minahlee Could you help review it ? Thanks. Failed test is flaky test. ``` Results : Failed tests: NotebookServerTest.testMakeSureNoAngularObjectBroadcastToWe