Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2422
Thanks @herval for the review. If you have time, you can also check the
unit test which is much more readable and will easy for you to get what I done
in this PR. (InterpreterFactoryTest, Interpret
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2422
Thanks @prabhjyotsingh for testing this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2422
Tried this on my local cluster, tested it with simultaneously with multiple
users. Looks good. Great improvement.
---
If your project is set up for it, you can reply to this email and have
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2422
@Leemoonsoo @jongyoul @prabhjyotsingh @felixcheung Could you help review
that ?
Here's some suggestion for you how to review it since it is a very large PR
* The overall change is the
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2422
@jongyoul Thanks for the quick review. I didn't intended to make such large
change at the beginning, but found many things are coupled together that I have
to make such large change. Several sugges
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2422
Wow ~ It changes pretty big including some code styles. Before reviewing
it, How about reverting code style? It's not related to feature itself, then we
can fix the style with minor pr. And can y
