[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2018-02-20 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2323 Great improvement. Submitted https://issues.apache.org/jira/browse/ZEPPELIN-3251 to consider showing rows/columns lazily on scrolling events as otherwise ui-grid has a significant overhead for

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2017-11-20 Thread vglushak
Github user vglushak commented on the issue: https://github.com/apache/zeppelin/pull/2323 > Now table renders HTML display in the cells and adjusts row height based on the content. There are some limitations for this feature. img, links works. But when I want to place button

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2017-05-19 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2323 GTM. Thanks @1ambda for great improvement. Merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2017-05-18 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2323 @Leemoonsoo just rebased and updated to use `white` color in each cell background in c56edca now it looks like ![image](https://cloud.githubusercontent.com/assets/4968473/2623

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2017-05-14 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2323 @Leemoonsoo Oops. I missed that feature. 1. Now table renders HTML display in the cells ![image](https://cloud.githubusercontent.com/assets/4968473/26039691/f7bfe146-3958

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2017-05-14 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2323 Bright version looks better for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2017-05-14 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2323 @Leemoonsoo Colorizing (even rows) is cognitively better because we are not confused when investigating closer rows. Here are more bright versions https://cloud.githubuse

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2017-05-14 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2323 And this PR adds background in rows. Master branch ![image](https://cloud.githubusercontent.com/assets/1540981/26033572/048722ea-387d-11e7-99da-1f940daa4347.png) This PR

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2017-05-14 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2323 Each cell in table supposed to print html. For example ``` %sh echo -e "%table key\tvalue\nsun\t%html http://www.freeiconspng.com/uploads/sun-icon-4.jpg>" ``` This PR

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2017-05-11 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2323 @guptarajat Hi, refer the last GIF. "persist" means that all state of table is saved in the note.josn. For example, sorting state will be saved after this PR but it is not in current master. ---

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2017-05-10 Thread guptarajat
Github user guptarajat commented on the issue: https://github.com/apache/zeppelin/pull/2323 "all these things are persisted and synchronized among web socket clients" What does this mean? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2017-05-10 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2323 Here's few feedbacks. 1. Table does not refreshed after height / width of paragraph change. TBD 2. How about remove 'type' in column table option? - Removed -

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2017-05-10 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2323 Tested and overall it's great improvement! Here's few feedbacks. 1. Table does not refreshed after height / width of paragraph change. 2. How about remove 'type' in column t