[GitHub] zeppelin issue #1805: [ZEPPELIN-1850] Introduce Webpack (front)

2016-12-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1805 Tested `console.log` in dev and dist. It now works as expected. LGTM and merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this

[GitHub] zeppelin issue #1805: [ZEPPELIN-1850] Introduce Webpack (front)

2016-12-27 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1805 @Leemoonsoo ### Remove `console.log` in dist I missed it. Previously, grunt stripped all `console.log` using this config ``` uglify: { ... 'drop_conso

[GitHub] zeppelin issue #1805: [ZEPPELIN-1850] Introduce Webpack (front)

2016-12-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1805 @1ambda Great improvement! Tested and it works well. One thing is, previously console.log() was printed only in dev mode. After this change, console.log() is printed both dev and di

[GitHub] zeppelin issue #1805: [ZEPPELIN-1850] Introduce Webpack (front)

2016-12-26 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1805 @AhyoungRyu I didn't know about ZEPPELIN-1805 but good to hear that it is solved by this PR. Also, docs was updated to include `npm run dev` command in 8442eba :) --- If your project is

[GitHub] zeppelin issue #1805: [ZEPPELIN-1850] Introduce Webpack (front)

2016-12-26 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1805 @1ambda To quickly test this branch, I tried to change some css components and html, js files. It's working really nicely(and super fast). Great work indeed! Seems it solved [ZEPPELIN-1805](ht

[GitHub] zeppelin issue #1805: [ZEPPELIN-1850] Introduce Webpack (front)

2016-12-25 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1805 So coool! I tested following your instructions and it worked like a charm 👍 And live-reloading time remarkably decreased. LGTM!!! --- If your project is set up for it, yo