Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1762
LGTM and merge to master if there're no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1762
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user FireArrow commented on the issue:
https://github.com/apache/zeppelin/pull/1762
And after rebasing master the failure is gone. Some kind of race in the
test? Anyway, it doesn't seem to be related to the changes in this pull request
---
If your project is set up for it, you
Github user FireArrow commented on the issue:
https://github.com/apache/zeppelin/pull/1762
Failure seems unrelated... It fails with a null pointer here:
https://github.com/FireArrow/zeppelin/blob/ZEPPELIN-1810%5D/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1762
Please check the build failure, but it might be a flaky test.
Otherwise, LGTM. Tested on master with these changes on top of #1757 and
all looks good with relative path trust store.
---
