[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2017-01-11 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1758 @AlexanderShoshin Thanks! Will Merge if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2017-01-11 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue: https://github.com/apache/zeppelin/pull/1758 @AhyoungRyu, thanks for the note. I've removed an url to the notebook. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2017-01-10 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1758 @AlexanderShoshin Checked again and it looks nice. Except the minor suggestion, LGTM. Thanks for your effort and the awesome tutorial note! --- If your project is set up for it, you can repl

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2017-01-09 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue: https://github.com/apache/zeppelin/pull/1758 I've added a new commit to convert the notebook to 0.7.0 format because I found that [9013620](https://github.com/apache/zeppelin/pull/1758/commits/9013620e1c835c66a849467e1ea15d43fa2a778

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2017-01-09 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue: https://github.com/apache/zeppelin/pull/1758 Sorry, I was not able to work on this issue during last weeks. @AhyoungRyu, I will make the corrections soon. Thanks --- If your project is set up for it, you can reply to this em

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2017-01-03 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1758 @AlexanderShoshin Seems the below two things need to be done before merge 1. revert the last commit [9013620](https://github.com/apache/zeppelin/pull/1758/commits/9013620e1c835c66a849467e1

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-20 Thread rawkintrevo
Github user rawkintrevo commented on the issue: https://github.com/apache/zeppelin/pull/1758 @AlexanderShoshin I think what @zjffdu and @bzz meant was that you could possibly call out this notebook in some where like [`docs/interpreter/flink.md`](https://github.com/apache/zeppelin/blo

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-20 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue: https://github.com/apache/zeppelin/pull/1758 @bzz, I am not sure. We already have a *Word Count* example there to describe `Flink` usage. Where should we place the link to this example? --- If your project is set up for it, you can

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-20 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1758 @AlexanderShoshin Right that would be better. So sorry about that ㅠ_ㅠ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-20 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue: https://github.com/apache/zeppelin/pull/1758 I am confused a bit :) @AhyoungRyu, do I need to drop my last commit or not? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-19 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1758 Is there any other feedback, or was everything addressed and we shall merge it now? Saw @zjffdu 's > How about refer this note in flink.md ? @AlexanderShoshin do you think it's w

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-17 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1758 @AlexanderShoshin Actually it was my bad. I checked again and [this commit](https://github.com/apache/zeppelin/pull/1758/commits/fe2a39ec38ad2aed4b65e37c96e7b1dfd3f3489b) is perfectly working.

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-17 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1758 Thanks for your quick update! Since #1780 is trying to update the all tutorial notes' format to the latest one, having older format of note can't be best solution I think. Not sure, but a

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-16 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue: https://github.com/apache/zeppelin/pull/1758 I've converted notebook to 0.6.2 format. So it should be displayed correctly now. [ZeppelinHub vew](https://www.zeppelinhub.com/viewer/notebooks/aHR0cHM6Ly9yYXcuZ2l0aHVidXNlcmNvbnRlbn

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-15 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue: https://github.com/apache/zeppelin/pull/1758 Oh, it should not looks like this. It might be another problem of new notebook json structure. I will correct this. --- If your project is set up for it, you can reply to this email and

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-15 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1758 Thank you for the such precise explanation. Tested again and it works well! BTW some markdown paragraphs are not shown like below, so i didn't noticed that there are some description in her

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-15 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue: https://github.com/apache/zeppelin/pull/1758 @zjffdu, should we do this in current PR or make a new issue for the documentation improving? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-15 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue: https://github.com/apache/zeppelin/pull/1758 @tae-jun, I found that **ZeppelinHub** can't display new notebooks correctly. It is because the note.json structure was changed after [ZEPPELIN-212](https://issues.apache.org/jira/browse/

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-15 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue: https://github.com/apache/zeppelin/pull/1758 @AhyoungRyu, thank you for your notes! * I've changed `wget` to `curl` as you suggested. * As for the error message with "permission denied" I think it is because `%sh` paragraphs

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-14 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1758 How about refer this note in Flink.md ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-14 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1758 @AlexanderShoshin Thanks for your contribution! While I was just quickly looking through this example note in my Zeppelin, couple of things were noticed. - AFAIK, OSX doesn't have `wg

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-14 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue: https://github.com/apache/zeppelin/pull/1758 Yes, but ZeppelinHub does not show all the paragraphs. I will try to find out the reason. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2016-12-14 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1758 [Link for the note on ZeppelinHub](https://www.zeppelinhub.com/viewer/notebooks/aHR0cHM6Ly9yYXcuZ2l0aHVidXNlcmNvbnRlbnQuY29tL0FsZXhhbmRlclNob3NoaW4vemVwcGVsaW4tZXhhbXBsZS9tYXN0ZXIvbm90ZWJvb2tzL0Zsa