[GitHub] zeppelin issue #1751: ZEPPELIN-1786. Refactor LivyHelper

2016-12-21 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1751 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] zeppelin issue #1751: ZEPPELIN-1786. Refactor LivyHelper

2016-12-19 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1751 Just a minor recommendation, rest LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] zeppelin issue #1751: ZEPPELIN-1786. Refactor LivyHelper

2016-12-19 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1751 @felixcheung The new bug is fixed. CI fail is not relevant. ``` 04:42:36,519 ERROR org.apache.zeppelin.search.LuceneSearch:120 - Failed to open index dir RAMDirectory@615184ee lockFact

[GitHub] zeppelin issue #1751: ZEPPELIN-1786. Refactor LivyHelper

2016-12-19 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1751 Please hold on the merge. I find another bug in livy interpreter. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] zeppelin issue #1751: ZEPPELIN-1786. Refactor LivyHelper

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1751 LGTM CI was passing, merging if no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] zeppelin issue #1751: ZEPPELIN-1786. Refactor LivyHelper

2016-12-17 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1751 @Leemoonsoo @felixcheung Thanks for review, comments are addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] zeppelin issue #1751: ZEPPELIN-1786. Refactor LivyHelper

2016-12-17 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1751 only a couple of minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] zeppelin issue #1751: ZEPPELIN-1786. Refactor LivyHelper

2016-12-17 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1751 LGTM and merge to master if there're no further discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1751: ZEPPELIN-1786. Refactor LivyHelper

2016-12-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1751 ping @prabhjyotsingh @bzz @felixcheung @Leemoonsoo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] zeppelin issue #1751: ZEPPELIN-1786. Refactor LivyHelper

2016-12-14 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1751 @prabhjyotsingh @bzz @felixcheung Please help review. The failed test is not relevant. ``` 16/12/14 08:08:03 INFO RemoteActorRefProvider$RemotingTerminator: Remote daemon shut