Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1639
CI is green now.
Looks great to me, merging to master if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@felizbear great!
From my experience, if you, as PR author, elaborate on the CI failure, in
case of any, it usually speeds merging things up.
---
If your project is set up for it, you can reply
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1639
You guys rock! ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1639
Thank you @1ambda !
@felizbear as soon as #1659 with CI improvements was merged, let's rebase
and see if we can merge this guy
---
If your project is set up for it, you can reply to this ema
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@felizbear Could you resolve conflict?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1639
Regarding to
- selecting proper version of node and npm
- centeralizing bulild tasks through npm scripts section
are being discussed in #1659. It would be helpful to give a fee
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@1ambda wow GREAT WORK! Thanks a lot for your effort!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@bzz I will do that thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@1ambda great job!
Could you please re-purpose (interactive rebase, basically) #1639 to
contain only CI improvements, so it does not include anything from this PR?
Then we can merge
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1639
Short Summary of #1659
1. it seems that travis only accepts `.mavenrc`
2. even with MAVEN_OPTIONS, maven-assembly-plugins caused OOM error, so
update it to 3.0.0 (usually pluginManageme
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@felizbear
I think something is happening while building `zeppelin-web` module
```
// recently passed PR CI:
https://travis-ci.org/apache/zeppelin/builds/177018840
https:/
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@felizbear After you modified maven options, heap was increase
```
// before
[INFO] Zeppelin: Server ... SUCCESS [
12.294 s]
[INFO] Zeppelin: Pac
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@bzz I don't think `maven clean` removes `.tmp` even in master. `grunt
clean` however does the job well
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1639
Experimenting with heap size sounds good, if that is the reason CI fails.
But it would be much easier to judge, if somebody could summarize current
CI failure here.
On the frontend build
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@felizbear
We can increase HEAP size by setting this command to `.travis.yml`
```
before_install:
echo "MAVEN_OPTS=-Xmx2048m" >> ~/.mavenrc
```
---
If your project
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@felizbear IMO,
- babelified code may not be optimized code (slower than codes written by
people)
- babelifying takes time
---
If your project is set up for it, you can reply to th
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
But also it's weird. The only difference in build is the babel task, which
just can't take over a minute. Or can it? :/
---
If your project is set up for it, you can reply to this email and hav
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@felizbear But we can reduce in next step :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@1ambda well, i was overly optimistic saying that the build time change is
virtually non-existent :(
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@bzz @felizbear
I just tested total build time of the `zeppelin-web` module on my computer.
CPU: 2.5 GHz Intel Core i7
RAM: 16 GB 1600 MHz DDR3
OS : OSX 10.11.6
JAVA: 1
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@bzz If we need more heap I think we can modify `.travis.yml` like
```
env:
global:
MAVEN_OPTS="-Xmx2048m -XX:MaxPermSize=1024m"
```
---
If your project is set up fo
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
Thank you @bzz for your detailed comment and suggestions.
> it's impact on build time
The impact on build time is virtually non-existent. There is some impact on
reload time dur
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1639
Thank you for good effort and contribution @felizbear !
Please, expect that usually reviews do take some time.
One thing that @1ambda brought that would be nice to understand better
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@felizbear Of course! But I do not completely understand about Zeppelin's
Travis CI, so we gonna need some help from committers ð
Oh, it just failed again with the same error. But I'm w
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@tae-jun I'm gonna trigger the build one more time. If it fails, could you
help me out with `.travis.yml`? Let's try to merge it ASAP guys.
---
If your project is set up for it, you can reply
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@felizbear `grunt test` passed :)
```
$ grunt test
...
PhantomJS 1.9.8 (Mac OS X 0.0.0): Executed 84 of 84 SUCCESS (0.861 secs /
0.831 secs)
Done, without errors.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@felizbear That makes sense! Then it's ok with me :)
I tested three commands (`serve` `test` `build`) and also worked with me.
I had removed `bower_components` and `node_modules` before
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@1ambda `grunt test` works well for me. Does it fail only in this branch?
e.g. `master` works fine for you?
Also, CI failed for this PR. Any advice?
---
If your project is set up for i
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@1ambda, @tae-jun
Thanks for reviewing guys.
@tae-jun
Auto-opening browser is actually my least-favorite feature; I removed it
for two reasons
1. It always opens the def
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@1ambda +1 for webpack
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1639
`grunt serve` and `grunt build` work will but `grunt test` failed. I am not
sure this is due to the change in this PR
```
$ grunt test
...
Running "karma:unit" (karma)
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1639
Nice move! ð I've always wanted to use ES6.
I tested and everything worked as expected.
But it seems like you turned off opening a browser when livereload server
on.
I
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1639
Really great! Let me test this PR :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
34 matches
Mail list logo
