[GitHub] zeppelin issue #1391: ZEPPELIN-1403. Should maintain the using port list

2016-11-29 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1391 Having a `PortProvider` as injectable dependency, that incapsulates all the logic about picking the port numbers sounds great! --- If your project is set up for it, you can reply to this email and ha

[GitHub] zeppelin issue #1391: ZEPPELIN-1403. Should maintain the using port list

2016-11-24 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1391 @bzz Sorry for delay, I was in vacation in the last 2 weeks. Regarding move it to other places rather than static, I am thinking to use a PortProvider class to wrap all the logic and of course this

[GitHub] zeppelin issue #1391: ZEPPELIN-1403. Should maintain the using port list

2016-11-08 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1391 @zjffdu test plan sounds great. My only concern was - may we can find a better place for this state, rather than `static` ? Move it somewhere, where if does not require to be static, but can