[GitHub] zeppelin issue #1281: [ZEPPELIN-1290] Refactor Navbar Controller

2016-08-08 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1281 Awesome, Merging if there is no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] zeppelin issue #1281: [ZEPPELIN-1290] Refactor Navbar Controller

2016-08-08 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1281 LGTM! CI is also green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] zeppelin issue #1281: [ZEPPELIN-1290] Refactor Navbar Controller

2016-08-08 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1281 Sure, let me take a look at it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] zeppelin issue #1281: [ZEPPELIN-1290] Refactor Navbar Controller

2016-08-08 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1281 @prabhjyotsingh I have Selenium test `testGroupPermission` failing on this PR, but can't find why. Could you take a look since you made that test? --- If your project is set up for it, you

[GitHub] zeppelin issue #1281: [ZEPPELIN-1290] Refactor Navbar Controller

2016-08-04 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1281 Re-trigger CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o