Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1185
Looks great to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1185
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1185
re-trigger CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1185
@astroshim Right. And agree with @felixcheung. Let do that in separate PR
then :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1185
+1 for 404 - maybe useful but could be a separate PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1185
@AhyoungRyu Thank you for your opinion.
Your idea is great but now is redirected all to home when requested wrong
path. (you can see the related code
[here](https://github.com/apache/zeppel
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1185
@astroshim Good catch! How about adding 404 page (like github does) instead
of just redirecting `Home` without any message. In 404 page, we can add sth
like "This is not the notebook page you a
