Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1168
I think we are already on the path of multiple PRs, wich sounds great to me!
@jongyoul shall we close this guy then?
---
If your project is set up for it, you can reply to this email and have
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1168
@bzz
I created a JIRA issue for this:
https://issues.apache.org/jira/browse/ZEPPELIN-1709
We can resolve this in 1 PR or can split it into multiples. I think we can
resolve these
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1168
@jongyoul how do you think, could you interactively rebase this branch to
have only `./_tools/*` changes? Or is it better to start a JIRA issue and close
this guy?
@1ambda do you know any way
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1168
@bzz Yes, I also don't think it's good idea to reformat all of codes. I
like your suggestion to adopt IDE formatter first. Let's find a way to sync
both of IntelliJ and Eclipse formatters.
---
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1168
Got it. Let's may be change PR title to WIP or even may be close it for now
but keep the branch and create a dedicated JIRA issue and link this work there?
It's a bigger effort that we initia
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1168
checkstyle in my PR is too strict and if we push it, too many error occurs
while checking style. I don't know how to handle with it. What do you think of
it?
---
If your project is set up for i
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1168
Sounds good! Let's rebase on master and make CI happy again first? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1168
@bzz Sure, I agree. it's kind of separate issue. I think enforcing code
format at first supporting formatter later would be a good plan. How about you?
---
If your project is set up for it, you
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1168
Do you think we should merge it as is and address eclipse formatter in the
separate issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1168
Yes, I think it's good idea on having stricter checkstyle.
Let me know if you want me to try again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1168
@bzz I've found Intellij doesn't export all of some configurations. We need
to enforce the format by configuring checkstyle.xml.
---
If your project is set up for it, you can reply to this email
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1168
@bzz Thanks for the suggestion. I think we need to update docs and it's
time to install Eclipse by myself in order to check the difference between
Eclipse and Intellij. Thanks Alex.
---
If your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1168
I have applied `ZeppelinStyle` Java formatter in Eclipse and re-formatted
`ZeppelinServer.java` here is the diff below
```
diff --git
a/zeppelin-server/src/main/java/org/apache/zeppelin/s
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1168
@jongyoul do you think we should update our documentation for contributors,
mentioning this IDE setup as well?
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1168
Ready to review. Could you please check Eclipse's one? Open
ZeppelinServer.java and reformat it and check if something's different or not.
---
If your project is set up for it, you can reply to
15 matches
Mail list logo
