[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI

Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1100 CI is green, merging if there is no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1100 @corneadoug yeah I did :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI

Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1100 @AhyoungRyu Can you rebase your branch please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1100 @corneadoug All CI builds failed. Seems they are related with [ZEPPELIN-1016](https://issues.apache.org/jira/browse/ZEPPELIN-1016) or [ZEPPELIN-1126](https://issues.apache.org/jira/browse/ZEPP

[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1100 @corneadoug Really appreciate for your effort! I addressed your last comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI

Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1100 Latest commit (41413df) can also be reverted --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI

Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1100 In the case of login from credential page, its a separate issue, you shouldn't be able to do that. I created an issue: https://issues.apache.org/jira/browse/ZEPPELIN-1123 and will take care

[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1100 Tested and overall working well. Found two (minor) problems When i login from Credential page, list not refreshed after logged in ![credential1](https://cloud.githubusercontent.com/

[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1100 CI failure is not related and is fixed under [ZEPPELIN-1063](https://issues.apache.org/jira/browse/ZEPPELIN-1063) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1100 @Leemoonsoo Since this PR needs #1030's extended API, I rebased from master. Maybe now it works properly. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1100 Ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1100 I'm keep getting `GET http://localhost:8080/api/credential 405 (Method Not Allowed)`, when i visit credential menu. @AhyoungRyu Could you check? ![image](https://cloud.githubuserconten

[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1100 @felizbear This PR can be tested after #1030 merged as I described in the above. * **Register** : you don't need to register if you don't want. It needs [shiro authentication setting

[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI

Github user felizbear commented on the issue: https://github.com/apache/zeppelin/pull/1100 Not sure how to test in the browser because I have to log in, but I have no clue how to register. And don't really understand why I have to do it to access settings. Link to documentati

[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI

Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1100 Really great feature! Thanks for making this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] zeppelin issue #1100: [ZEPPELIN-1054] Improve "Credentials" UI

Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1100 Looks good to me, \cc @corneadoug @felizbear for review of the frontend part --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro