[GitHub] zeppelin issue #1087: Shell interpreter test and doc

2016-06-30 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1087 @fvaleri Got it. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] zeppelin issue #1087: Shell interpreter test and doc

2016-06-30 Thread fvaleri
Github user fvaleri commented on the issue: https://github.com/apache/zeppelin/pull/1087 Another CI job failed even this time on zeppelin-web module. One is still running but it is very slow (32 min now). ``` [ERROR] Failed to execute goal com.github.eirslett:frontend-maven

[GitHub] zeppelin issue #1087: Shell interpreter test and doc

2016-06-30 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1087 The failure is flaky and irrelevant but we need to ensure all other tests passed. Could you please re-trigger CI? --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1087: Shell interpreter test and doc

2016-06-30 Thread fvaleri
Github user fvaleri commented on the issue: https://github.com/apache/zeppelin/pull/1087 @bzz @jongyoul Now should be ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1087: Shell interpreter test and doc

2016-06-30 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1087 Great clean up and improvement @fvaleri! While you and @jongyoul are both here - how do you think guys, would it make sense to take care of Shell part of the [ZEPPELIN-804](https://issues.apa

[GitHub] zeppelin issue #1087: Shell interpreter test and doc

2016-06-30 Thread fvaleri
Github user fvaleri commented on the issue: https://github.com/apache/zeppelin/pull/1087 @jongyoul done and CI is ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

Re: [GitHub] zeppelin issue #1087: Shell interpreter test and doc

2016-06-30 Thread Federico Valeri
Done and tested again. Trevis is OK. This is only a small refactoring to make it testable. 2016-06-30 1:50 GMT+02:00 jongyoul : > Github user jongyoul commented on the issue: > > https://github.com/apache/zeppelin/pull/1087 > > Could you please rebase this from current master? > > > ---

[GitHub] zeppelin issue #1087: Shell interpreter test and doc

2016-06-29 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1087 Could you please rebase this from current master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi