[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...

2016-05-24 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/904#issuecomment-221467292 thanks, looks like Selenium tests have been busted by a merged code change. thanks for opening ZEPPELIN-876. --- If your project is set up for it, you c

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...

2016-05-24 Thread mwkang
Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/904#issuecomment-221245539 I made 2 issue for failing CI. [ZEPPELIN-876](https://issues.apache.org/jira/browse/ZEPPELIN-876), [ZEPPELIN-877](https://issues.apache.org/jira/browse/ZEP

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...

2016-05-24 Thread mwkang
Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/904#issuecomment-221210218 @bzz Thanks for your comment. It is really helpful. and now I understand 100%! :smile: --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...

2016-05-24 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/904#issuecomment-221207147 @mwkang no problem! yes, JIRA issue for failing CI with label `flaky-build` (even if it does not block this PR) would help us improving the CI --- If your

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...

2016-05-24 Thread mwkang
Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/904#issuecomment-221204328 @bzz I think I don't understand 100%. So I want to more clearly what you are saying. If I am impolite, I am so sorry. Is the meaning I make a JIRA issu

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...

2016-05-23 Thread bzz
Github user bzz commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/904#issuecomment-221178211 Guys, in effort to improve build stability, would it be reasonable to have some kind of agreement that in case of such build failures - we create a JIRA issues f

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...

2016-05-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/904#issuecomment-221161426 [The first CI profile](https://travis-ci.org/apache/incubator-zeppelin/jobs/132442409) runs this test and it is passing. Other CI failure is unrelated to

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...

2016-05-23 Thread mwkang
Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/904#issuecomment-221146929 @Leemoonsoo Part of Ci are failed. Because.. [ERROR] Failed to execute goal on project zeppelin-zrinterpreter: Could not resolve dependencies for

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...

2016-05-23 Thread mwkang
GitHub user mwkang reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/904 [ZEPPELIN-835]Don't persist authentication info into note.json ### What is this PR for? Don't persist authentication info into note.json ### What type of PR is it? Bug F

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...

2016-05-23 Thread mwkang
Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/904#issuecomment-221143687 Of course. I close the PR and re-open to re-trigger the ci. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...

2016-05-23 Thread mwkang
Github user mwkang closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/904 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...

2016-05-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/904#issuecomment-221075370 @mwkang Thanks for the fix. It looks good. Do you mind re-trigger the CI? --- If your project is set up for it, you can reply to this email and have your