[GitHub] [zeppelin] zjffdu commented on issue #3466: [Zeppelin-4341] fix role setting when using multiple realms

2019-10-31 Thread GitBox
zjffdu commented on issue #3466: [Zeppelin-4341] fix role setting when using multiple realms URL: https://github.com/apache/zeppelin/pull/3466#issuecomment-548640748 It is merged, could you close this PR ? @primerano This is

[GitHub] [zeppelin] zjffdu commented on issue #3466: [Zeppelin-4341] fix role setting when using multiple realms

2019-10-29 Thread GitBox
zjffdu commented on issue #3466: [Zeppelin-4341] fix role setting when using multiple realms URL: https://github.com/apache/zeppelin/pull/3466#issuecomment-547705171 Thanks @primerano LGTM will merge if no more comments This

[GitHub] [zeppelin] zjffdu commented on issue #3466: [Zeppelin-4341] fix role setting when using multiple realms

2019-10-21 Thread GitBox
zjffdu commented on issue #3466: [Zeppelin-4341] fix role setting when using multiple realms URL: https://github.com/apache/zeppelin/pull/3466#issuecomment-544775075 @alexott Some tests are failed, probably due to flaky test, could you re-trigger them ? --

[GitHub] [zeppelin] zjffdu commented on issue #3466: [Zeppelin-4341] fix role setting when using multiple realms

2019-10-16 Thread GitBox
zjffdu commented on issue #3466: [Zeppelin-4341] fix role setting when using multiple realms URL: https://github.com/apache/zeppelin/pull/3466#issuecomment-542963314 @primerano Could you paste the travis build link here ? Need to make sure CI pass before merging.

[GitHub] [zeppelin] zjffdu commented on issue #3466: [Zeppelin-4341] fix role setting when using multiple realms

2019-10-08 Thread GitBox
zjffdu commented on issue #3466: [Zeppelin-4341] fix role setting when using multiple realms URL: https://github.com/apache/zeppelin/pull/3466#issuecomment-539775118 Thanks @primerano LGTM This is an automated message from th

[GitHub] [zeppelin] zjffdu commented on issue #3466: [Zeppelin-4341] fix role setting when using multiple realms

2019-09-30 Thread GitBox
zjffdu commented on issue #3466: [Zeppelin-4341] fix role setting when using multiple realms URL: https://github.com/apache/zeppelin/pull/3466#issuecomment-536547799 Right master use java 8. You can skip sap module via adding `-pl !sap` in maven build command -

[GitHub] [zeppelin] zjffdu commented on issue #3466: [Zeppelin-4341] fix role setting when using multiple realms

2019-09-28 Thread GitBox
zjffdu commented on issue #3466: [Zeppelin-4341] fix role setting when using multiple realms URL: https://github.com/apache/zeppelin/pull/3466#issuecomment-536245303 No worries, @primerano I just notice that this Pr is for branch-0.8, do you find the same issue in master branch ?

[GitHub] [zeppelin] zjffdu commented on issue #3466: Zeppelin-4341

2019-09-28 Thread GitBox
zjffdu commented on issue #3466: Zeppelin-4341 URL: https://github.com/apache/zeppelin/pull/3466#issuecomment-536192669 Could you update the PR title ? This is an automated message from the Apache Git Service. To respond to t