[GitHub] zeppelin issue #1777: [ZEPPELIN-1831] Fix paragraph control dropdown alignme...

2016-12-23 Thread marchpig
Github user marchpig commented on the issue: https://github.com/apache/zeppelin/pull/1777 @prabhjyotsingh I resolved the conflict. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin pull request #1792: Change gitignore for font files

2016-12-22 Thread marchpig
GitHub user marchpig opened a pull request: https://github.com/apache/zeppelin/pull/1792 Change gitignore for font files ### What is this PR for? Some web fonts were changed by 5552319378e8361a16c91df2ba3cdf5519b74d58 but `.gitignore` was not changed accordingly

[GitHub] zeppelin pull request #1777: [ZEPPELIN-1831] Fix paragraph control dropdown ...

2016-12-16 Thread marchpig
GitHub user marchpig opened a pull request: https://github.com/apache/zeppelin/pull/1777 [ZEPPELIN-1831] Fix paragraph control dropdown alignment ### What is this PR for? Paragraph control dropdown is displayed outside when the browser width is small. To fix this problem

[GitHub] zeppelin pull request #1771: [ZEPPELIN-1820] Fix action bar layout broken is...

2016-12-15 Thread marchpig
GitHub user marchpig opened a pull request: https://github.com/apache/zeppelin/pull/1771 [ZEPPELIN-1820] Fix action bar layout broken issue ### What is this PR for? Action bar buttons and paragraph are overlapped when the browser width is small. To fix this issue, this PR

[GitHub] zeppelin pull request #1733: [ZEPPELIN-1753] Fix blank notename issue

2016-12-12 Thread marchpig
Github user marchpig closed the pull request at: https://github.com/apache/zeppelin/pull/1733 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1733: [ZEPPELIN-1753] Fix blank notename issue

2016-12-12 Thread marchpig
GitHub user marchpig reopened a pull request: https://github.com/apache/zeppelin/pull/1733 [ZEPPELIN-1753] Fix blank notename issue ### What is this PR for? Note ID is displayed on action bar after pressing enter key with blank notename. This is because the scope variable

[GitHub] zeppelin issue #1733: [ZEPPELIN-1753] Fix blank notename issue

2016-12-09 Thread marchpig
Github user marchpig commented on the issue: https://github.com/apache/zeppelin/pull/1733 @cuspymd Thank you for review! Maybe ZEPPELIN-1763 should be fixed by another PR. :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-09 Thread marchpig
Github user marchpig commented on the issue: https://github.com/apache/zeppelin/pull/1730 @tae-jun It works well! Thank you very much for accepting my opinions. :smiley: I think that handling `~Trash` prefix in the future is fine to me because it is not a bug but just my opinion

[GitHub] zeppelin issue #1728: [ZEPPELIN-1754] PING request stacking on websocket rec...

2016-12-08 Thread marchpig
Github user marchpig commented on the issue: https://github.com/apache/zeppelin/pull/1728 I've tested it and works as expected. LGTM! But please trigger CI again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] zeppelin pull request #1733: [ZEPPELIN-1753] Fix blank notename issue

2016-12-08 Thread marchpig
Github user marchpig closed the pull request at: https://github.com/apache/zeppelin/pull/1733 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1733: [ZEPPELIN-1753] Fix blank notename issue

2016-12-08 Thread marchpig
GitHub user marchpig reopened a pull request: https://github.com/apache/zeppelin/pull/1733 [ZEPPELIN-1753] Fix blank notename issue ### What is this PR for? Note ID is displayed on action bar after pressing enter key with blank notename. This is because the scope variable

[GitHub] zeppelin pull request #1733: [ZEPPELIN-1753] Fix blank notename issue

2016-12-07 Thread marchpig
GitHub user marchpig reopened a pull request: https://github.com/apache/zeppelin/pull/1733 [ZEPPELIN-1753] Fix blank notename issue ### What is this PR for? Note ID is displayed on action bar after pressing enter key with blank notename. This is because the scope variable

[GitHub] zeppelin pull request #1733: [ZEPPELIN-1753] Fix blank notename issue

2016-12-07 Thread marchpig
Github user marchpig closed the pull request at: https://github.com/apache/zeppelin/pull/1733 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1733: [ZEPPELIN-1753] Fix blank notename issue

2016-12-07 Thread marchpig
GitHub user marchpig opened a pull request: https://github.com/apache/zeppelin/pull/1733 [ZEPPELIN-1753] Fix blank notename issue ### What is this PR for? Note ID is displayed on action bar after pressing enter key with blank notename. This is because the scope variable for

[GitHub] zeppelin issue #1723: [ZEPPELIN-1747] Fix Korean notename input problem

2016-12-03 Thread marchpig
Github user marchpig commented on the issue: https://github.com/apache/zeppelin/pull/1723 @tae-jun Thanks for your quick reply. I triggered CI again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin pull request #1723: [ZEPPELIN-1747] Fix Korean notename input probl...

2016-12-03 Thread marchpig
GitHub user marchpig reopened a pull request: https://github.com/apache/zeppelin/pull/1723 [ZEPPELIN-1747] Fix Korean notename input problem ### What is this PR for? Korean notename is incorrectly typed on Firefox. This PR fixes the issue by changing placeholder attribute of

[GitHub] zeppelin pull request #1723: [ZEPPELIN-1747] Fix Korean notename input probl...

2016-12-03 Thread marchpig
Github user marchpig closed the pull request at: https://github.com/apache/zeppelin/pull/1723 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1723: [ZEPPELIN-1747] Fix Korean notename input probl...

2016-12-03 Thread marchpig
GitHub user marchpig opened a pull request: https://github.com/apache/zeppelin/pull/1723 [ZEPPELIN-1747] Fix Korean notename input problem ### What is this PR for? Korean notename is incorrectly typed on Firefox. This PR fixes the issue by changing placeholder attribute of

[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem

2016-11-27 Thread marchpig
Github user marchpig commented on the issue: https://github.com/apache/zeppelin/pull/1684 I've tested it on both Win7 and Ubuntu 12.04. > Win7 32bit (IE11, Chrome 54.0) > Ubuntu 12.04 64bit (Firefox 43.0) This issue only occurred on Ubuntu 12.04 so I thin

[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem

2016-11-26 Thread marchpig
Github user marchpig commented on the issue: https://github.com/apache/zeppelin/pull/1684 @AhyoungRyu This issue occurs on the two different browsers in my environment(Ubuntu 16.04 64-bit). > Firefox 50.0 > Chromium browser 53.0.2785.143 So I guess it d

[GitHub] zeppelin pull request #1684: Fix filter icon not displaying problem

2016-11-25 Thread marchpig
GitHub user marchpig opened a pull request: https://github.com/apache/zeppelin/pull/1684 Fix filter icon not displaying problem ### What is this PR for? Filter icon is not displayed properly due to the css font-family order. ### What type of PR is it? Bug Fix