[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2141 Selenium tests are red in Travis but due to: `SparkParagraphIT.testSqlSpark:185 » NoSuchElement Unable to locate element: {"... ` https://travis-ci.org/guicaro/zeppelin

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2141 @AhyoungRyu Fixed the issue with my commits, big shoutout to @DrIgor for helping resolve my issue! I also updated the tests (ex. `testSingleDynamicFormSelectForm

[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...

Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2154 @AhyoungRyu Thanks so much for your help. Even after starting my local repo from scratch and fetching from upstream I can't seem to get to #2154 using `test_zeppelin_pr.py`. Here are

[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...

Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2154 @AhyoungRyu I've been trying to get #2156 working without any luck, completely my fault in not following the correct flow. I get into all kinds of merge conflicts even after I switch t

[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...

Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2154 @AhyoungRyu just glanced through comments in #2156 I also wondered why changes in check boxes did not trigger a run when placed next to a select form and with the `Run on selection change` glad

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2141 @AhyoungRyu no worries, will be glad to review your work, fix `testMultipleDynamicFormsSameType` and fox my commits, will definetly ping you about this last issue :) Thanks --- If your project

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2141 Quick question, what is the behavior when we have more than 2 select forms? Shouldn't we also have a **"Run on selection"** check box? I believe this was one of the pain point

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2141 @AhyoungRyu I'm currently looking at why testMultipleDynamicFormsSameType is failing. It now fails after I rebased from master. It's the test case that includes two select forms in

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2141 Thanks again @1ambda it all worked like a charm and now all green :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2141 @1ambda Thanks, I actually did setup Travis while I was developing, I did not realize that every commit triggered a build so I deactivated my Zeppelin fork on Travis after I noticed this (so only

[GitHub] zeppelin pull request #2141: [ZEPPELIN-1720] Adding tests to verify behaviou...

GitHub user guicaro opened a pull request: https://github.com/apache/zeppelin/pull/2141 [ZEPPELIN-1720] Adding tests to verify behaviour of dynamic forms ### What is this PR for? Adding Selenium tests to ensure proper behaviour of dynamic forms. ### What type of PR is